style: correcting all outstanding mypy errors - #113
Conversation
Fixing almost all outstanding `mypy` typing errors. There are a few where I have used the `# type: ignore[<rule>]` as I couldn't work out how to resolve things but this should mean that `mypy` passes both locally and in `pre-commit.ci` and so going forward we can stay on top of the type-hints and ensure things always pass. Explicitly exclude `tests/` from type checking.
fa5899c to
9e1d7db
Compare
|
|
fisher568
left a comment
There was a problem hiding this comment.
mypy passes on my machine if I run it as part of pre-commit (e.g. by making a perfunctory change and attempting to commit it). I think this is good to merge, but why is the tests folder explicitly being ignored now, I get quite a few failures when I run mypy on all files?
I was keen to get the I've noted it as a task in #115. Thanks for the ✅ |
Closes #32
Fixing almost all outstanding
mypytyping errors.There are a few where I have used the
# type: ignore[<rule>]as I couldn't work out how to resolve things but thisshould mean that
mypypasses both locally and inpre-commit.ciand so going forward we can stay on top of thetype-hints and ensure things always pass.
Explicitly exclude
tests/from type checking.Before submitting a Pull Request please check the following.