add version for kafka tag #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroumani
requested changes
Feb 17, 2021
I've added the kafkatag to the json file, i think first time through I was in "developer mode" to reuse/adapt what was there. But I see adding the value to the json it become much more flexible for us when testing an inflight version. |
hroumani
reviewed
Feb 23, 2021
| "sparkclient": "repo1.maven.org/maven2/com/ibm/event/ibm-db2-eventstore-client-spark-2.4.6/2.0.1.0/ibm-db2-eventstore-client-spark-2.4.6-2.0.1.0.jar", | ||
| "hadoopversion":"2.6", | ||
| "scopt211version":"3.5.0" | ||
| "scopt211version":"3.5.0", |
There was a problem hiding this comment.
I know this was here before but what's this used for ? I didn't see us consuming this for any versioning ?
| "scopt211version":"3.5.0", | ||
| "kafkatag":"v2.0.0.5" | ||
| } , | ||
| "dev" : { |
There was a problem hiding this comment.
What's the idea behind this ? Is it just a placeholder to make it easier for devs to make changes going forward ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic story requirements futhfilled, will look if we need a subsequent story to expand support for developers using not released versions of ES with Kafka