Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terraform docs for drift and formatting #5194

Merged
merged 15 commits into from
Mar 19, 2024
Merged

Update terraform docs for drift and formatting #5194

merged 15 commits into from
Mar 19, 2024

Conversation

h-romeus
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

riccardo-angelilli
riccardo-angelilli suggested changes Mar 12, 2024
View reviewed changes
website/docs/d/project_config.html.markdown Outdated Show resolved Hide resolved
website/docs/d/project_environment.html.markdown Outdated Show resolved Hide resolved
website/docs/r/project_config.html.markdown Show resolved Hide resolved
website/docs/r/project.html.markdown Outdated Show resolved Hide resolved
website/docs/r/project.html.markdown Outdated Show resolved Hide resolved
website/docs/r/project.html.markdown Outdated Show resolved Hide resolved
website/docs/r/project_config.html.markdown Outdated Show resolved Hide resolved
@h-romeus
Copy link
Contributor Author

@riccardo-angelilli please take another look.

riccardo-angelilli
riccardo-angelilli approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@riccardo-angelilli riccardo-angelilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now is fine

@riccardo-angelilli
Copy link
Contributor

@h-romeus sync your fork with the remote main branch, then @hkantare can merge

@h-romeus
Copy link
Contributor Author

image

I don't think I have the option to do so @riccardo-angelilli

@riccardo-angelilli
Copy link
Contributor

riccardo-angelilli commented Mar 14, 2024 •
edited
Loading

@h-romeus oh you need to do it from your forked repo, click Sync fork and press Update branch

Screenshot 2024-03-14 at 14 00 59

@riccardo-angelilli
Copy link
Contributor

ok, ready for merge

@hkantare hkantare merged commit 0f1e328 into IBM-Cloud:master Mar 19, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@h-romeus @ismirlia
Update terraform docs for drift and formatting (IBM-Cloud#5194)
f5d7e2e 
* Update project.html.markdown for drift

* Update project_config formatting

* Update project_environment format

* Update project format

* Update project_config format

* Update project_config.html.markdown

* Update project_environment.html.markdown

* Update project_config.html.markdown

* Update project_config.html.markdown

* Update project_environment.html.markdown

* Update project.html.markdown

* Update project.html.markdown

* Update project.html.markdown

* Update project_config.html.markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardo-angelilli riccardo-angelilli riccardo-angelilli approved these changes

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-romeus @riccardo-angelilli @hkantare