fix(vpc-routing-table): support removing of advertise routes and accept routes from array #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt routes from arrays
|
I do not see any test changes. Are there tests for this feature? |
|
@powellquiring Test cases were already there for this feature. And some cases are now enhanced to capture this scenario. |
hkantare
reviewed
Jan 17, 2024
| vpc = ibm_is_vpc.testacc_vpc.id | ||
| name = "%s" | ||
| accept_routes_from_resource_type=[] | ||
| advertise_routes_to=[] |
There was a problem hiding this comment.
We need to set explictly to empty array ? what happens if user remove the argument itself from tf file advertise_routes_to
There was a problem hiding this comment.
It is a optional and computed field. so if user removes the argument itself, then there won't be any change shown.
user has to explicitly set empty array.
michaelkad
added a commit
that referenced
this pull request
Jan 23, 2024
- Add VM no storage to deployment type Fixed catalog service extensions and values metadata params of workspace ds (#4957) update CHANGELOG Bump up version to 1.60.0 feat(Cloud Databases): Database user password complexity validation (#4931) * feat(Cloud Databases): Database user password complexity validation * update tests to conform to new complexity rules * fix password validation edgecases * add test case for password beginning with special char * fix regexp * refactor of db users * delete and create ops manager users when updating * validate adminpassword, update docs Add new service Logs Router to IBM Terraform Provider (#4945) * Added new service Logs Router to IBM Terraform Provider * Ran detect-secrets and re-generated secrets.baseline * Added emptycredentialsError check for Logs Router Client Error Signed-off-by: Ian Reyes <ianreyes99@gmail.com> * Removed redundant general provider set up information. Fixed Service Subcategories Signed-off-by: Ian Reyes <ianreyes99@gmail.com> --------- Signed-off-by: Ian Reyes <ianreyes99@gmail.com> add virtual optical device update err msg Add missing changes Update go.mod (#4963) - Update go.mod: bluemix-go version Fix IBM i documentation bug (#4969) * Fix IBM i documentation bug On several documentation pages, it incorrectly implied that IBMi was the only usable OS for that resource/data source. * Update help URLs Regenerate Projects TF to fix generated doc and samples (#4961) * fix integration test * fix integration test * fix integration test * fix name * pr comments * pr comments * fix doc * fix doc * new version * new version * new version * new version * update code to the latest SDK level * fix integration tests * fix integration tests * fix integration tests * fix integration tests * address PR comment * typo * typo * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * add wait for create and delete * add wait for create and delete * . * fix integration tests * fix integration tests * fix integration tests * fix integration tests * fix integration tests * regenerate * new code generation * new generated code * point to latest sdk * point to latest sdk * adjust test cases and doc * adjust samples * update to latest node sdk * merge with master * Update project_instance.html.markdown Fixing formatting issues * Update project_event_notification.html.markdown * Update README.md * Update variables.tf * Update project_event_notification.html.markdown * new version * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * feat: projects graph fragment pattern * align with origin/master * update test cases * restore README.md and versions.tf to master branch * remove duplicated entries * feat: graph fragment pattern poc * feat: restore definition blocks * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * update doc * update doc * fix test cases * commit generated code * commit fix * commit fix * test cases * test cases * test cases * test cases * updates * upgrade to latest go sdk * update generated doc * update generated code * updated secrets baseline * update code to latest API changes * secrets * fix secrets * update samples with real values * update secrets * update secrets * update generated code to the latest API definition * update secrets baseline * merge with master * merge with master * merge with master * update code to the latest SDK level * address some review comments * address PR comments * address PR comments * update to latest sdk level * update to latest sdk level * update to latest sdk level * merge with master * update to the latest sdk level * format test case * regenerate the code with generator fixes * regenerate code * fix "inputs" and "settings" properties --------- Co-authored-by: dvesperini <dvesperini@gmail.com> Co-authored-by: knee-na <130502432+knee-na@users.noreply.github.com> Co-authored-by: Mark-Kulube <markkulube@ibm.com> Removed Logs Router Provider Signed-off-by: Ian Reyes <ianreyes99@gmail.com> Update pi_user_data to accept string input (#4974) * Add string support for pi_user_data field in instance creation * Add new user data test * Updated pi_user_data documentation * Remove duplicate import dependabot: bump actions/setup-go from 4 to 5 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> new host link endpoint commits (#4970) * new host link endpoint commits * add host link agent argument and example. Fixed RHEL7 repos to RHEL8 --------- Co-authored-by: Justin Kanz <jmkanz@ibm.com> Add mtu and accessConfig flags to subnet create commands for terraform (#4690) * Add mtu and accessConfig flags to subnet create commands for terraform * Fix terraform compile errors * Fix terraform compile error from yaml changes * Clean up warnings in powervs provider * Fix bug checking region instead of zone for satellite check * Hide shared processor pool and IBMi license arguments from being set in satellite location * Fix typing issues in MTU and access config Three issues here: - There is no schema.TypeInt64, so I have to set this field to schema.TypeInt. Pretend this value is an int and then cast it back to an int64. This an issue with the terraform sdk. - I accidentally set schema.Int on access config where it should be schema.TypeString - All passed in variables by the user need to be set or else the sdk and/or service broker can't safeguard against bad values correctly * Update new network field satellite documentation * Revert nullable name change Due to incompatibility between to the two service brokers, this change has to be undone to maintain consistency. * Update go mod files for new sdk version * Add satellite network acceptance test * Update mtu and jumbo descriptions * Add access-config validation to terraform feat: add new service mqcloud Service Credentials secret addition (#4926) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Feature is snapshot consistency group and Migration PR (#4973) * GO-SDK Updated * ibm_is_snapshot_consistency_group development * Consistency Group changes to Snapshot * Documentation changes for snapshot * SDK changes * Bankup Policy Jobs Changes * included_content development * match_resource_type development * Implemented Documentation Fix * PR review comments incorporated * SDK update * Updated to released SDK Fix typo in filename fix detect secret marking false positive feat(Cloud Databases): Redis Database User RBAC support (#4982) Update version to 1.5.6 fix(Cloud Databases): fix Unwrap return value for go 1.18 compat (#4991) Signed-off-by: Alex Hemard <alexhemard@gmail.com> Address comments update power version update issue fixed ibm_is_subnet_reserved_ip (#4988) Adding Flexible IOPS (#4992) * - Add IOPs to volume - Update documentation - Make strorageType required for COS import - Update Volume Create Disk Type Required - Update Create Instance Storeage Type to Required - vol_upd_iops_level * Update version to 1.5.6 * update documentation * update power version --------- Co-authored-by: michael kad <michaelkad> Removing Support For Power VPN Create (#4993) * Add Deprectated for VPN Create * Update text * Update version to 1.5.6 * Update version to 1.5.6 * update power version --------- Co-authored-by: michael kad <michaelkad> Feature(share-crr): Share cross region replication (#4995) * feature(share-crr): Share cross region replication * sdk updates * updated last sync options * updated sdk and latest_sync * updated schema and doc * tf example * doc and schema correction * acceptance test * sdk changes * updated sdk * added nil check * doc link added * remove common folder sdk * doc update Add variable to ok address review comments dependabot: bump golang.org/x/crypto from 0.16.0 to 0.17.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0. - [Commits](golang/crypto@v0.16.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Enhancement: Added operating system attributes to is images data sources (#4998) * Enhancement: Added operating system attributes to is images data sources * set the values * test and doc changes added enhancement to one step delegate resolver in is_vpc resolved delete issue for the floated nics on bm server Bump up versio to 1.61.0-beta0 Regenerate projects provider based off the latest go sdk (#5003) * new version * new version * new version * update code to the latest SDK level * fix integration tests * fix integration tests * fix integration tests * fix integration tests * address PR comment * typo * typo * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * add wait for create and delete * add wait for create and delete * . * fix integration tests * fix integration tests * fix integration tests * fix integration tests * fix integration tests * regenerate * new code generation * new generated code * point to latest sdk * point to latest sdk * adjust test cases and doc * adjust samples * update to latest node sdk * merge with master * Update project_instance.html.markdown Fixing formatting issues * Update project_event_notification.html.markdown * Update README.md * Update variables.tf * Update project_event_notification.html.markdown * new version * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * feat: projects graph fragment pattern * align with origin/master * update test cases * restore README.md and versions.tf to master branch * remove duplicated entries * feat: graph fragment pattern poc * feat: restore definition blocks * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * update doc * update doc * fix test cases * commit generated code * commit fix * commit fix * test cases * test cases * test cases * test cases * updates * upgrade to latest go sdk * update generated doc * update generated code * updated secrets baseline * update code to latest API changes * secrets * fix secrets * update samples with real values * update secrets * update secrets * update generated code to the latest API definition * update secrets baseline * merge with master * merge with master * merge with master * update code to the latest SDK level * address some review comments * address PR comments * address PR comments * update to latest sdk level * update to latest sdk level * update to latest sdk level * merge with master * update to the latest sdk level * format test case * regenerate the code with generator fixes * regenerate code * fix "inputs" and "settings" properties * regenerated doc and samples * fix samples * terraform * terraform * terraform * terraform * terraform --------- Co-authored-by: dvesperini <dvesperini@gmail.com> Co-authored-by: knee-na <130502432+knee-na@users.noreply.github.com> Co-authored-by: Mark-Kulube <markkulube@ibm.com> Feature(vpc Advertise routes): Support route advertising in vpc (#5005) * added advertised route support * doc updates for routing table/s * Change advertise_routes_to from List to HashSet and modify create, update and read methods accordingly * Add latest generated go sdk * update with latest sdk * add beta maturity to sdk * corrected docs as per review comment * updated go mod * Update resource_ibm_is_bare_metal_server.go * rm common --------- Co-authored-by: Bhavesh Shrivastav <bhavesh.shrivastav@ibm.com> Co-authored-by: Ujjwal Kumar <Ujjwal.Kumar1@ibm.com> Bugs fixes for Secrets Manager (#5008) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> dependabot: bump crazy-max/ghaction-import-gpg from 6.0.0 to 6.1.0 Bumps [crazy-max/ghaction-import-gpg](https://github.com/crazy-max/ghaction-import-gpg) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/crazy-max/ghaction-import-gpg/releases) - [Commits](crazy-max/ghaction-import-gpg@v6.0.0...v6.1.0) --- updated-dependencies: - dependency-name: crazy-max/ghaction-import-gpg dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix: add multipart support for mqcloud service (#5010) * fix: multipart fix for mqcloud (cherry picked from commit e7253421db30943d3582ce07d9504a2117f30ce1) * enable enforceReservedDeploymentPlan --------- Co-authored-by: Shuaib Bapputty <shuaib.bapputty@ibm.com> added a nil check for boottarget of bms Delete wait logic changes Changes wrt latest schematics sdk Revert VPN Changes, will go in at end Q1 SM docs bug fix (#5018) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> fix(docs): UI-33634: mention correct image name in image data source example Bump up version to 1.61.0 update go version to 1.19 CD scc doc updates Latest SCC description updates dependabot: bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.3...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix mtu requirement bug There a bug with the MTU field in terraform where ExactlyOneOf requires Jumbo or MTU to be set, but the intent was to allow at most one of those fields to be set, but are optional. Add satellite features and add support to the user can direct which security groups are added to their workers Add volume clone resource and data source (#5019) * Add volume clone resource and data source * Docs improved * power-go-client update in go.mod * feedback resolved * testcase func renamed * Resolved conflicts * feedback resolved renamed targetReplicationEnabled to replicationEnabled * Alphabetically sorted documentation attributes. * Improved minor naming convention & docs * Added some use case scenarios * Feedback resolved * Fix: Document formatting * Making use of the correct cloudInstanceId constant add resource instance sample config code part in the website doc listing all the connection for transit gateway over the pagination set SCC Update Jan 2024 (#5032) * init commit * Updates: - Added ENV_VARS needed to run ACC tests - Added a validator for the resource scc_instance_settings - Allow the ability for the scc_instance_settings to be imported - Completed the functional testing for resource ibm_scc_instance_settings - Added documentation for scc_instance - Added documentation for scc_instance_settings * adding updates to scc_instance docs * Changed the format of the website documentation * Change the details of the NOTE for scc_instance * Modifying scc test runs --------- Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> fix(vpc-routing-table): support removing of advertise routes and accept routes from array (#5039) * fix(vpc-routing-table): support removing of advertise routes and accept routes from arrays * updated test cases Projects issue #2672 - "Terraform sees inputs as changed when they have not" (#5042) * typo * typo * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * add wait for create and delete * add wait for create and delete * . * fix integration tests * fix integration tests * fix integration tests * fix integration tests * fix integration tests * regenerate * new code generation * new generated code * point to latest sdk * point to latest sdk * adjust test cases and doc * adjust samples * update to latest node sdk * merge with master * Update project_instance.html.markdown Fixing formatting issues * Update project_event_notification.html.markdown * Update README.md * Update variables.tf * Update project_event_notification.html.markdown * new version * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * terraform * feat: projects graph fragment pattern * align with origin/master * update test cases * restore README.md and versions.tf to master branch * remove duplicated entries * feat: graph fragment pattern poc * feat: restore definition blocks * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * regenerate the terraform code based on latest YAML * update doc * update doc * fix test cases * commit generated code * commit fix * commit fix * test cases * test cases * test cases * test cases * updates * upgrade to latest go sdk * update generated doc * update generated code * updated secrets baseline * update code to latest API changes * secrets * fix secrets * update samples with real values * update secrets * update secrets * update generated code to the latest API definition * update secrets baseline * merge with master * merge with master * merge with master * update code to the latest SDK level * address some review comments * address PR comments * address PR comments * update to latest sdk level * update to latest sdk level * update to latest sdk level * merge with master * update to the latest sdk level * format test case * regenerate the code with generator fixes * regenerate code * fix "inputs" and "settings" properties * regenerated doc and samples * fix samples * terraform * terraform * terraform * terraform * terraform * fix marshal strings * secrets * resolve conflicts --------- Co-authored-by: knee-na <130502432+knee-na@users.noreply.github.com> Co-authored-by: Mark-Kulube <markkulube@ibm.com> added a nil check on data source of bm servers Soft remove the datasources for secretManager v1 Schematics agent related fixes for GA (#5041) * increased timeout of agent deploy to 30min * Fix for agent and policy tags crash issue * removed x-feature-agents header references * added refresh_token for agent update * Updated agent resource doc with latest * enchanced agent update * Modified wait logic of agent deploy with latest agent status code * Minor edits to agent testcases support parameters for resource instance datasource remove forcenew from workerpool fields in cluster resource and added ApplyOnce (#4955) * remove forcenew from workerpool fields in cluster resource and added ApplyOnce * doc update * remove ForceNew lines, added ApplyOnce in vpc taints, Doc Update * import on create * log and error change * remove some deprecated code, updated create and update funcs. * id vars * tains not availble in read, no point making it computed * remove irrelevant update for worker_num in doc related to applyonce * review comments and vpc testcase * test import_on_create in classic * Update ibm/service/kubernetes/resource_ibm_container_vpc_worker_pool.go Co-authored-by: Zoltán Illés <zoltan.illes@live.com> * Update ibm/service/kubernetes/resource_ibm_container_vpc_worker_pool.go Co-authored-by: Zoltán Illés <zoltan.illes@live.com> * review * Update ibm/service/kubernetes/resource_ibm_container_vpc_cluster.go Co-authored-by: Zoltán Illés <zoltan.illes@live.com> * Update ibm/service/kubernetes/resource_ibm_container_vpc_cluster.go Co-authored-by: Zoltán Illés <zoltan.illes@live.com> * Update ibm/service/kubernetes/resource_ibm_container_vpc_cluster.go Co-authored-by: Zoltán Illés <zoltan.illes@live.com> * labels apply once in classic cluster resource * more test steps for classic wp * more test steps for vpc wp * kms in create cluster * comment header year * conflict fix * call update after create terrafrom to apply rest of the modifications * update after cluster creation * remove enable kms from create, as it is present in update too --------- Co-authored-by: Zoltán Illés <zoltan.illes@live.com> Update terraform example (#5050) * Update powervs terraform example with workspace creation * Update workspace creation construct * Update datacenter location comment * Remove explicit depends on text from example SM fixes (#5045) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all --------- Co-authored-by: Yonathan-Yellin <yonathan.yellin@ibm.com> Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> Co-authored-by: Tatyana <tatyanab@il.ibm.com> Co-authored-by: Idan Adar <iadar@il.ibm.com> Bump up version to 1.62.0-beta0 add isWaitForPIInstanceShutoff modify update vopt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #5036
Output from acceptance testing: