Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - ops_manager User Creation #4790

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

omaraibrahim
Copy link
Collaborator

@omaraibrahim omaraibrahim commented Sep 7, 2023

ops_manager User Creation broke after the user management refactor in this PR: ad38584

This bug fix is meant to bring back ops_manager user creation.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMMongoDBShardingDatabaseInstanceBasic'
--- PASS: TestAccIBMMongoDBShardingDatabaseInstanceBasic (2892.46s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	2897.485s
...
make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstancePostgresBasic'
--- PASS: TestAccIBMDatabaseInstancePostgresBasic (1134.99s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1140.039s
make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMMongoDBEnterpriseDatabaseInstanceBasic'
--- PASS: TestAccIBMMongoDBEnterpriseDatabaseInstanceBasic (8791.58s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	8796.480s

password = "password12password"
type = "database"
password = "password$12password"
type = "ops_manager"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested with MongoDBEE? Could you please add a test to cover that as well?

@obai-1 obai-1 merged commit 3e6865a into IBM-Cloud:master Sep 13, 2023
2 checks passed
Blintmester pushed a commit to Blintmester/terraform-provider-ibm that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants