Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry cloud connection create/update when vpc is unavailable #4766

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Retry cloud connection create/update when vpc is unavailable #4766

merged 5 commits into from
Sep 14, 2023

Conversation

rachari
Copy link
Collaborator

@rachari rachari commented Aug 25, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@rachari rachari marked this pull request as ready for review August 25, 2023 13:36
@rachari
Copy link
Collaborator Author

rachari commented Aug 25, 2023

@rmoralesjr @yussufsh Can you review this?

rmoralesjr
rmoralesjr reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@rmoralesjr rmoralesjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address Yussuf's comments and I am good.

ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
yussufsh
yussufsh requested changes Sep 9, 2023
View reviewed changes
ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_cloud_connection.go Outdated Show resolved Hide resolved
yussufsh
yussufsh approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hkantare hkantare merged commit a2c0516 into IBM-Cloud:master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@rmoralesjr rmoralesjr Awaiting requested review from rmoralesjr

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachari @yussufsh @rmoralesjr @hkantare