Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update container-registry SDK #4706

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Update container-registry SDK #4706

merged 2 commits into from
Jul 24, 2023

Conversation

brackendawson
Copy link
Contributor

So that the terraform provider can operate the eu-fr2 region.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4286

Output from acceptance testing:

$ make testacc TESTARGS='run="TestAccIBMCr.*"'
=== RUN   TestAccIBMCrNamespacesDataSourceBasic
--- PASS: TestAccIBMCrNamespacesDataSourceBasic (17.09s)
=== RUN   TestAccIBMCrNamespaceBasic
--- PASS: TestAccIBMCrNamespaceBasic (25.23s)
=== RUN   TestAccIBMCrNamespaceAllArgs
--- PASS: TestAccIBMCrNamespaceAllArgs (36.73s)
=== RUN   TestAccIBMCrRetentionPolicyAllArgs
--- PASS: TestAccIBMCrRetentionPolicyAllArgs (23.64s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/registry	103.720s
...

@brackendawson
Update container-registry SDK
677e26c 
So that the terraform provider can operate the eu-fr2 region.
hkantare
hkantare requested changes Jul 21, 2023
View reviewed changes
.secrets.baseline Outdated Show resolved Hide resolved
@hkantare hkantare merged commit 93080ee into IBM-Cloud:master Jul 24, 2023
@brackendawson brackendawson deleted the registry-eu-fr2 branch July 24, 2023 12:02
benbuchanan pushed a commit to benbuchanan/terraform-provider-ibm that referenced this pull request Aug 17, 2023
@brackendawson @benbuchanan
Update container-registry SDK (IBM-Cloud#4706)
d7eb3bc 
* Update container-registry SDK

So that the terraform provider can operate the eu-fr2 region.

* Update detect secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibm_cr_namespace always provision in Washington
2 participants
@brackendawson @hkantare