feat(Cloud Database): support offline restore for MongoDB EE PITR

[alexhemard]

• Add support for offline_restore flag for MongoDB EE Point-in-Time Restores, used in a disaster recovery scenario.
• Support for an alternative provider to use cross-region testing in acceptance tests.
• Replaces the IcdDBRegion variable with a Region method, to reference the same defaults as the provider configuration

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMMongoDBEnterpriseDatabaseInstancePITR'

...

=== RUN   TestAccIBMMongoDBEnterpriseDatabaseInstancePITR
=== PAUSE TestAccIBMMongoDBEnterpriseDatabaseInstancePITR
=== CONT  TestAccIBMMongoDBEnterpriseDatabaseInstancePITR
--- PASS: TestAccIBMMongoDBEnterpriseDatabaseInstancePITR (14068.91s)

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstancePostgresBasic|TestAccIBMDatabaseInstance_Etcd_Basic|TestAccIBMDatabaseInstance_Redis_Basic'

...

=== RUN   TestAccIBMDatabaseInstance_Etcd_Basic
=== PAUSE TestAccIBMDatabaseInstance_Etcd_Basic
=== RUN   TestAccIBMDatabaseInstancePostgresBasic
=== PAUSE TestAccIBMDatabaseInstancePostgresBasic
=== RUN   TestAccIBMDatabaseInstance_Redis_Basic
=== PAUSE TestAccIBMDatabaseInstance_Redis_Basic
=== CONT  TestAccIBMDatabaseInstance_Etcd_Basic
=== CONT  TestAccIBMDatabaseInstance_Redis_Basic
=== CONT  TestAccIBMDatabaseInstancePostgresBasic
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (966.60s)
--- PASS: TestAccIBMDatabaseInstance_Etcd_Basic (1103.58s)
--- PASS: TestAccIBMDatabaseInstancePostgresBasic (1321.67s)
PASS

[obai-1]

I believe this function is replacing IcdDbRegion. Previously IcdDbRegion = os.Getenv("ICD_DB_REGION").
I don't see that env var in this list. Are we good here?

[alexhemard]

This function replaces IcdDbRegion and will use the same defaults the provider uses to configure region.
see https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/ibm/provider/provider.go#L93