Remove deprecated scaling attributes #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaraibrahim
changed the title
alexhemard
reviewed
Jul 17, 2023
| service == "databases-for-cassandra" || | ||
| service == "databases-for-enterprisedb" { | ||
| if planPhase { | ||
| groupDefaults, err := getDatabaseServiceDefaults(service, meta) |
There was a problem hiding this comment.
getDatabaseServiceDefaults function appears unused and should be removed
| func resourceIBMDatabaseInstanceDiff(_ context.Context, diff *schema.ResourceDiff, meta interface{}) (err error) { | ||
| err = flex.ResourceTagsCustomizeDiff(diff) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| service := diff.Get("service").(string) | ||
| planPhase := diff.Get("plan_validation").(bool) |
There was a problem hiding this comment.
We should also deprecate/remove plan_validation from the schema since it is no longer used
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flat list scaling attributes are deprecated and should no longer be used per the following PRs:
This PR is to remove the attributes for good. Please refer to the docs here: https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database#sample-database-instance-by-using-group-attributes for the current scaling attributes.
Many scaling attributes have been deprecated in favor of groups scaling. This PR is to officially remove them and update the tests.
For more details please about deprecated attributes see the following blog post: https://www.ibm.com/cloud/blog/announcements/new-features-and-rearchitecturing-of-ibm-cloud-databasess-terraform-provider
Community Note
Relates OR Closes #0000
Output from acceptance testing: