Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAM Identity: account settings #4221

Merged
merged 1 commit into from
Dec 14, 2022
Merged

IAM Identity: account settings #4221

merged 1 commit into from
Dec 14, 2022

Conversation

pooraniss-ibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-account-settings branch 2 times, most recently from 96b3c34 to 96f078d Compare December 6, 2022 11:47
@pooraniss-ibm
Copy link
Contributor Author

pooraniss-ibm commented Dec 6, 2022 •
edited
Loading

@hkantare
Inside go.mod and go.sum files I have used the latest version of platform-go-sdk version v0.31.0

if an older version is being used then the resourcecontroller is failing. this needs to be fixed by the respective contributor.

I have all the changes added for iamidentity resources and datasources.

@pooraniss-ibm
Copy link
Contributor Author

Screenshot 2022-12-06 at 11 43 04

@pooraniss-ibm
Copy link
Contributor Author

@hkantare rebased and updated, can be reviewed and merged

hkantare
hkantare reviewed Dec 13, 2022
View reviewed changes
ibm/service/iamidentity/resource_ibm_iam_account_settings.go Outdated
@@ -306,7 +357,10 @@ func resourceIbmIamAccountSettingsUpdate(context context.Context, d *schema.Reso
updateAccountSettingsOptions.SetMfa(mfa_str)
hasChange = true
}

if d.HasChange("user_mfa") {
// TODO: handle UserMfa of type TypeList -- not primitive, not model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to handle the update of "user_mfa"

ibm/service/iamidentity/resource_ibm_iam_account_settings_test.go
@@ -126,9 +128,15 @@ func testAccCheckIbmIamAccountSettingsUpdateConfig() string {
restrict_create_platform_apikey = "%s"
if_match = "%s"
mfa = "%s"
user_mfa {
iam_id = "iam_id"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test case to add multiple users and update operation to remove or add users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added two tests, one is to test with an empty list of user_mfa, and another one with 2 users.

@pooraniss-ibm
Copy link
Contributor Author

@hkantare Hii, the comments are addressed and PR is updated :)

@hkantare hkantare merged commit c52e557 into IBM-Cloud:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pooraniss-ibm @hkantare