Support for transit gateway unbound gre tunnel connections #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Dec 12, 2022
| - `remote_bgp_asn` - (Optional, Forces new resource, Integer) - The remote network BGP ASN (will be generated for the connection if not specified). This field only applies to network type `gre_tunnel` and `unbound_gre_tunnel` connections. | ||
| - `remote_gateway_ip` - (Optional, Forces new resource, String) - The remote gateway IP address. This field only applies to network type `gre_tunnel` and `unbound_gre_tunnel` connections. | ||
| - `remote_tunnel_ip` - (Optional, Forces new resource, String) - The remote tunnel IP address. This field only applies to network type `gre_tunnel` and `unbound_gre_tunnel` connections. | ||
| - `zone` - (Optional, Forces new resource, String) - The location of the GRE tunnel. This field only applies to network type `gre_tunnel` and `unbound_gre_tunnel` connections. |
There was a problem hiding this comment.
We don't have attribute description for "base_network_type" which was recently added
There was a problem hiding this comment.
Good catch, can't believe I missed that. It has been added.
| @@ -45,20 +45,21 @@ In addition to the argument reference list, you can access the following attribu | |||
| Nested scheme for `connections`: | |||
| - `created_at` - (String) The date and time the connection is created. | |||
| - `id` - (String) The unique identifier for the transit gateway connection to network either `VPC`, `classic`. | |||
| - `base_connection_id` - The ID of a network_type `classic` connection a tunnel is configured over. This field only applies to network type `gre_tunnel` connections. | |||
| - `base_connection_id` - The ID of a network_type `classic` connection a tunnel is configured over. This field applies to network type `gre_tunnel` or `unbound_gre_tunnel` connections. | |||
| - `base_network_type` - The type of network the unbound gre tunnel is targeting. This field is required for network type `unbound_gre_tunnel`. | |||
There was a problem hiding this comment.
The indentation is missed out
There was a problem hiding this comment.
The indentations have been fixed.
sarah-ulmer
force-pushed
the
tg-unbound-gre
branch
from
13e2eaa
to
63aadbd
Compare
sarah-ulmer
force-pushed
the
tg-unbound-gre
branch
from
3e72aeb
to
4243b52
Compare
|
@hkantare thank you for your review. I fixed the doc errors you pointed out and caught a few more, which have been fixed. Could you please review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Output from acceptance testing: