Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRS Fix: fixed pi_volume_group_action, pi_volume_group & data pi_volume_group_storage_details resources #4193

Merged
merged 2 commits into from
Nov 29, 2022
Merged

GRS Fix: fixed pi_volume_group_action, pi_volume_group & data pi_volume_group_storage_details resources #4193

merged 2 commits into from
Nov 29, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

@dhirendersingh19 dhirendersingh19 commented Nov 22, 2022 •
edited
Loading

…_source_ibm_pi_volume_group_storage_details resources

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

=== RUN   TestAccIBMPIVolumeGroupStorageDetailsDataSourceBasic
--- PASS: TestAccIBMPIVolumeGroupStorageDetailsDataSourceBasic (169.73s)
PASS
=== RUN   TestAccIBMPIVolumeGroupActionbasic
--- PASS: TestAccIBMPIVolumeGroupActionbasic (435.10s)
PASS
=== RUN   TestAccIBMPIVolumeGroupUpdate
--- PASS: TestAccIBMPIVolumeGroupUpdate (858.71s)
PASS
...

@dhirendersingh19
grs fix: fixed ibm_pi_volume_group_action, ibm_pi_volume_group & data…
8c8b116 
…_source_ibm_pi_volume_group_storage_details resources
@dhirendersingh19 dhirendersingh19 marked this pull request as ready for review November 22, 2022 15:36
@dhirendersingh19
Copy link
Collaborator Author

Fix GRS Resources

  • Fixed ID of ibm_pi_volume_group_storage_details data source
  • Added forceNew attribute for start/stop/reset schema in ibm_pi_volume_group_action resource
  • Fixed PIVolumeGroupsVolumeIds while importing ibm_pi_volume_group resource

@dhirendersingh19 dhirendersingh19 added the service/Power Systems Issues related to Power Systems label Nov 24, 2022
@dhirendersingh19
Copy link
Collaborator Author

@yussufsh can you review it?

yussufsh
yussufsh approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

@dhirendersingh19
Copy link
Collaborator Author

@hkantare can you review it?

@dhirendersingh19 dhirendersingh19 changed the title grs fix: fixed pi_volume_group_action, pi_volume_group & data pi_volume_group_storage_details resources GRS Fix: fixed pi_volume_group_action, pi_volume_group & data pi_volume_group_storage_details resources Nov 29, 2022
@hkantare hkantare merged commit 0c8353c into IBM-Cloud:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoralesjr rmoralesjr rmoralesjr approved these changes

@hkantare hkantare hkantare approved these changes

@yussufsh yussufsh yussufsh approved these changes

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhirendersingh19 @yussufsh @hkantare @rmoralesjr