Terraform Support for EPIC offering Create flow #3949
Conversation
| } | ||
| `, acc.Pi_cloud_instance_id, name, acc.Pi_image, acc.Pi_network_name, instanceHealthStatus) | ||
| `, acc.Pi_cloud_instance_id, name, acc.Pi_image, acc.Pi_network_name, instanceHealthStatus, acc.Pi_deployment_type) |
There was a problem hiding this comment.
The default value for deployment type, terraform-test-power, will not work. I am not sure pi_deployment_type can be set to "" but maybe that will work but if not you could make another dedicated test case for EPIC deployment types since this deployment type has other restrictions that the basic config does not have like it requires dedicated procs, tier1 storage and does not work on s922
There was a problem hiding this comment.
"" will work as already tested by her.
I asked her to integrate this with the existing test case to save on just adding new test func. This was before I came to know about the processors limitation.
Now, I will leave it up to you folks whether you want to have a new test case or use the existing one with some comment about the limitation to whoever will be using this env var.
There was a problem hiding this comment.
I told her I was OK to add a new test case unless you had a reason to not do that. So I am good with it.
Bhagyashri, can you please update the description with the passing statement for the new test case.
|
@bhagyagkwd please mark the already fixed comments above as resolved. Also, squash your commits into one single commit. |
bhagyagkwd
force-pushed
the
POWERIAAS-6670-EPIC
branch
from
fb1cc6a
to
b597f22
Compare
bhagyagkwd
force-pushed
the
POWERIAAS-6670-EPIC
branch
from
109bbdd
to
729fcce
Compare
* Terraform Support for EPIC offering Create flow * New Test Case for EPIC
* Terraform Support for EPIC offering Create flow * New Test Case for EPIC
Community Note
Relates OR Closes #0000
Output from acceptance testing: