Added fix for optional weight attribute's value #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for optional weight attr set to 0 when not provided.
weight default info added in docs.
hkantare
reviewed
May 12, 2022
| @@ -63,7 +63,7 @@ Review the argument references that you can specify for your resource. | |||
| - `port`- (Required, Integer) The port number of the application running in the server member. | |||
| - `target_address` - (Required, String) The IP address of the pool member. | |||
| - `target_id` - (Required, String) The unique identifier for the virtual server instance pool member. Required for network load balancer. | |||
| - `weight` - (Optional, Integer) Weight of the server member. This option takes effect only when the load-balancing algorithm of its belonging pool is `weighted_round_robin`, Minimum allowed weight is `0` and Maximum allowed weight is `100`. | |||
| - `weight` - (Optional, Integer) Weight of the server member. This option takes effect only when the load-balancing algorithm of its belonging pool is `weighted_round_robin`, Minimum allowed weight is `0` and Maximum allowed weight is `100`. When weight is not provided a default of 40 is returned. | |||
There was a problem hiding this comment.
in test case you said default is 50 but in docs its 40 can you confirm
There was a problem hiding this comment.
modified with right info.
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* Fix for optional weight attribute's value Fix for optional weight attr set to 0 when not provided. * ssh key removal * weight default info added in docs weight default info added in docs. * upd docs upd docs
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* Fix for optional weight attribute's value Fix for optional weight attr set to 0 when not provided. * ssh key removal * weight default info added in docs weight default info added in docs. * upd docs upd docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for optional weight attr set to 0 when not provided.
Community Note
Relates OR Closes #UI-21513
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-21513
Output from acceptance testing: