Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gateway & ip_address_range attribute for network resource #3585

Merged
merged 3 commits into from
May 4, 2022
Merged

Add gateway & ip_address_range attribute for network resource #3585

merged 3 commits into from
May 4, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

@dhirendersingh19 dhirendersingh19 commented Feb 15, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkbasic
--- PASS: TestAccIBMPINetworkbasic (48.84s)
PASS
=== RUN   TestAccIBMPINetworkGatewaybasic
--- PASS: TestAccIBMPINetworkGatewaybasic (54.00s)
PASS
...

@dhirendersingh19 dhirendersingh19 changed the title Add gateway & ip_address_range attribute in network resource Add gateway & ip_address_range attribute for network resource Feb 15, 2022
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Feb 17, 2022
yussufsh
yussufsh approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yussufsh yussufsh requested a review from hkantare March 10, 2022 10:47
@yussufsh
Copy link
Collaborator

@hkantare Please help with the review.

@yussufsh
Copy link
Collaborator

@hkantare ptal

@hkantare hkantare merged commit d3f2b58 into IBM-Cloud:master May 4, 2022
hkantare pushed a commit that referenced this pull request May 4, 2022
@dhirendersingh19 @hkantare
Add gateway & ip_address_range attribute for network resource (#3585)
fe5dccf 
* add gateway & ip_address_range attribute for network resource

* feedback resolved

* renamed pi_ipaddress_range params
@dhirendersingh19 dhirendersingh19 deleted the network_dev branch August 18, 2022 04:54
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@dhirendersingh19 @SunithaGudisagarIBM1
Add gateway & ip_address_range attribute for network resource (IBM-Cl…
2e84d81 
…oud#3585)

* add gateway & ip_address_range attribute for network resource

* feedback resolved

* renamed pi_ipaddress_range params
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@dhirendersingh19 @SunithaGudisagarIBM1
Add gateway & ip_address_range attribute for network resource (IBM-Cl…
1f477c5 
…oud#3585)

* add gateway & ip_address_range attribute for network resource

* feedback resolved

* renamed pi_ipaddress_range params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhirendersingh19 @yussufsh @hkantare