Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pi_network jumbo option #3255

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

yussufsh
Copy link
Collaborator

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@@ -146,6 +157,7 @@ func resourceIBMPINetworkRead(d *schema.ResourceData, meta interface{}) error {
d.Set("vlan_id", networkdata.VlanID)
d.Set(helpers.PINetworkName, networkdata.Name)
d.Set(helpers.PINetworkType, networkdata.Type)
d.Set(helpers.PINetworkJumbo, networkdata.Jumbo)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default if you create a pi network without jumbo it will be false?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@hkantare hkantare merged commit 4fb0690 into IBM-Cloud:master Oct 26, 2021
@yussufsh yussufsh deleted the jumbo branch November 15, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants