Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed review comments for Custom resolver docs #2997

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Addressed review comments for Custom resolver docs #2997

merged 2 commits into from
Sep 13, 2021

Conversation

DwitikrDash
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@DwitikrDash
Copy link
Contributor Author

@kavya498 @powellquiring addressed the review comments for the documentation. Please have a look.

@hkantare
Copy link
Collaborator

hkantare commented Sep 2, 2021

Can you please rebase the PR and fix conflicts

@DwitikrDash
Copy link
Contributor Author

There is no conflict now

@hkantare hkantare merged commit e24eaa6 into IBM-Cloud:master Sep 13, 2021
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong resource name used in ibm_dns_custom_resolver_forwarding_rule documentation
2 participants