fix: delete topic does not fail when topic does not exist #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunliWang
changed the title
JunliWang
changed the title
|
Can you please resolve the conflicts in go.sum |
hkantare
pushed a commit
that referenced
this pull request
Aug 18, 2021
* delete topic does not fail when topic does not exists * update deps
hkantare
pushed a commit
that referenced
this pull request
Sep 1, 2021
* fix: delete topic does not fail when topic does not exist (#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
hkantare
pushed a commit
that referenced
this pull request
Sep 3, 2021
* fix: delete topic does not fail when topic does not exist (#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
…2976) * delete topic does not fail when topic does not exists * update deps
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
…2976) * delete topic does not fail when topic does not exists * update deps
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
…2976) * delete topic does not fail when topic does not exists * update deps
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
…2976) * delete topic does not fail when topic does not exists * update deps
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
kavya498
pushed a commit
to kavya498/terraform-provider-ibm
that referenced
this pull request
Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976) * delete topic does not fail when topic does not exists * update deps * remove kms_key_policy.html.markdown Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
hkantare
pushed a commit
that referenced
this pull request
Dec 2, 2021
* fix: delete topic does not fail when topic does not exist (#2976) * delete topic does not fail when topic does not exists * update deps * fix: delete topic does not fail when topic does not exist (#2976) * delete topic does not fail when topic does not exists * update deps * Docs changed for maintaning consistency Co-authored-by: Junli Wang <wilmawang@ibm.com> Co-authored-by: Harshit-Gupta2 <harshit.gupta2@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue is:
https://ibm-cloudplatform.slack.com/archives/C53NF5MB4/p1628689859157700
the fix includes: