Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: image from volume #2682

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Feature: image from volume #2682

merged 1 commit into from
Jun 21, 2021

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented May 28, 2021 •
edited
Loading

Output from acceptance testing:

=== RUN   TestAccIBMISImage_fromVolume
no message sent
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISImage_fromVolume (616.05s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm	620.377s
...

@ujjwal-ibm ujjwal-ibm force-pushed the feature-is-imageFromVolume branch 2 times, most recently from 565059f to 69175f3 Compare May 28, 2021 10:30
@ujjwal-ibm ujjwal-ibm marked this pull request as ready for review May 28, 2021 12:51
@ujjwal-ibm ujjwal-ibm force-pushed the feature-is-imageFromVolume branch 2 times, most recently from f73943f to 288ceb2 Compare June 16, 2021 09:36
hkantare
hkantare reviewed Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@hkantare hkantare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a testcases also for the new feature and share the results of all testcases in the PR

ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Outdated Show resolved Hide resolved
ibm/resource_ibm_is_image.go Show resolved Hide resolved
website/docs/r/is_image.html.markdown Outdated Show resolved Hide resolved
@hkantare
Copy link
Collaborator

Resolve the conflicts of the docs

@ujjwal-ibm ujjwal-ibm force-pushed the feature-is-imageFromVolume branch 3 times, most recently from fbbfd1f to 061191b Compare June 18, 2021 19:07
@hkantare hkantare merged commit d7bcdde into IBM-Cloud:master Jun 21, 2021
@ujjwal-ibm ujjwal-ibm deleted the feature-is-imageFromVolume branch October 12, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujjwal-ibm @hkantare