Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop v0.12 in v2.0, add "engines" to package.json #79

Merged
merged 2 commits into from
Aug 2, 2017
Merged

drop v0.12 in v2.0, add "engines" to package.json #79

merged 2 commits into from
Aug 2, 2017

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Aug 2, 2017 •
edited
Loading

  • announce dropping support for node v0.12
  • also, add an engines field with value node ≥ 0.12 for now, to be updated later

Supports: #55

@srl295 srl295 added the docs label Aug 2, 2017
@srl295 srl295 added this to the v1.5.0 milestone Aug 2, 2017
@srl295 srl295 self-assigned this Aug 2, 2017
@srl295 srl295 mentioned this pull request Aug 2, 2017
Closed
@srl295 srl295 changed the title Add engines announce dropping node v0.12 in 2.0, add engines field in package.json Aug 2, 2017
@srl295 srl295 changed the title announce dropping node v0.12 in 2.0, add engines field in package.json announce dropping node v0.12 in 2.0, add "engines node≥0.12" Aug 2, 2017
@srl295 srl295 changed the title announce dropping node v0.12 in 2.0, add "engines node≥0.12" drop v0.12 in v2.0, add "engines" to package.json Aug 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.828% when pulling a7f03aa on srl295:add-engines into 9a59eec on IBM-Bluemix:master.

@srl295
Announce dropping support for node v0.12
671c585 
* add engines in package.json
* add a 'news' item to the README.

In support of IBM-Cloud#55
@srl295
Regenerate README.md
d15976f 
Supporting: IBM-Cloud#55
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.828% when pulling d15976f on srl295:add-engines into 9a59eec on IBM-Bluemix:master.

@srl295 srl295 merged commit d3acc94 into IBM-Cloud:master Aug 2, 2017
@srl295 srl295 deleted the add-engines branch August 2, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumaoka yumaoka yumaoka approved these changes

@hchawla1 hchawla1 hchawla1 approved these changes

@jugu jugu Awaiting requested review from jugu

@pgaglani1 pgaglani1 Awaiting requested review from pgaglani1

Assignees

@srl295 srl295

Labels
docs
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@srl295 @coveralls @yumaoka @hchawla1