Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL inconsistency with other gp clients #56

Closed
ckoberlein opened this issue Jan 11, 2017 · 1 comment
Closed

URL inconsistency with other gp clients #56

ckoberlein opened this issue Jan 11, 2017 · 1 comment
Labels
enhancement
Milestone
v1.4.0

Comments

@ckoberlein
Copy link

There is an inconsistency with the URLs used by different GP clients.

The gp-angular-client always ensures that /rest is included at the end of the URL used.

The gp-js-client always removes /rest from the end of the URL (and then appends later).

I suggest changing gp-js-client to match for consistency.
@srl295
Copy link
Contributor

srl295 commented Feb 20, 2017

This makes sense.

@srl295 srl295 added this to the v2.0.0 milestone Feb 20, 2017
This was referenced Feb 22, 2017
Closed
Open
@srl295 srl295 modified the milestones: v1.4.0, v2.0.0 Feb 24, 2017
srl295 added a commit to srl295/gp-js-client that referenced this issue Feb 24, 2017
@srl295
wip on IBM-Cloud#56
b3a36d5
srl295 added a commit to srl295/gp-js-client that referenced this issue Feb 24, 2017
@srl295
Add /rest instead of dropping it from the URL
1148f44 
* improve consistency with other clients.
* historical note:  /rest used to be NOT included in the URL from the GP broker.
(this was in the Experimental version- so a very old change.)
* this affects internal URL usage, and the INTERNAL _getUrl() function.

Fixes: IBM-Cloud#56
@srl295 srl295 mentioned this issue Feb 24, 2017
Merged
@srl295 srl295 closed this as completed in #62 Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
2 participants
@srl295 @ckoberlein