Rewrite logic for block quotes when using JAVAMSGFORMAT_ALL#139
Merged
jugu merged 4 commits intoIBM-Cloud:masterfrom Mar 20, 2019
Merged
Rewrite logic for block quotes when using JAVAMSGFORMAT_ALL#139jugu merged 4 commits intoIBM-Cloud:masterfrom
jugu merged 4 commits intoIBM-Cloud:masterfrom
Conversation
yumaoka
approved these changes
Mar 20, 2019
Contributor
yumaoka
left a comment
yumaoka
left a comment
There was a problem hiding this comment.
LGTM. Please resolve merge conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of converting single block quote to double block quotes fails to handle certain edge cases like
a simple line '(where the block quote is at the very end).Also the text obtained after converting single block quote to double single block quote may be a valid ICU message format, but may not be a valid java message format. Added additional check to make sure that the message pattern satisfies both ICU and java message format post double block quote conversion, with a fallback to the original text in case of compliance failure.