Skip to content

Properly handle multiple white space characters after property key#132

Merged
yumaoka merged 1 commit intoIBM-Cloud:masterfrom
yumaoka:javaprop-spaces
Feb 5, 2019
Merged

Properly handle multiple white space characters after property key#132
yumaoka merged 1 commit intoIBM-Cloud:masterfrom
yumaoka:javaprop-spaces

Conversation

@yumaoka
Copy link
Contributor

@yumaoka yumaoka commented Feb 4, 2019

gp-res-filter Java properties filter had a problem processing two or
more white space characters after key string. When two or more white
space characters appeared after key string, the first non-white space
character after them are interpreted as the first character of property
value, even the character is = or :. The fix handles both key1 val1 and key1 = val1 properly. Fixes #131.

gp-res-filter Java properties filter had a problem processing two or
more white space characters after key string. When two or more white
space characters appeared after key string, the first non-white space
character after them are interpreted as the first character of property
value, even the character is `=` or `:`. The fix handles both `key1
val1` and `key1     = val1` properly. Fixes IBM-Cloud#131.
@yumaoka yumaoka requested a review from jugu February 4, 2019 21:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 51.252% when pulling e6ef0a9 on yumaoka:javaprop-spaces into 49d608b on IBM-Cloud:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 51.252% when pulling e6ef0a9 on yumaoka:javaprop-spaces into 49d608b on IBM-Cloud:master.

Copy link
Contributor

@jugu jugu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yumaoka yumaoka merged commit 070b36e into IBM-Cloud:master Feb 5, 2019
@yumaoka yumaoka deleted the javaprop-spaces branch February 5, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java properties file import filter fails to handle extra spaces before k/v separator

3 participants