Supports <pathToBundleMapper> and <sourcePathToTargetMapper>#119
Merged
yumaoka merged 3 commits intoIBM-Cloud:masterfrom May 7, 2018
Merged
Supports <pathToBundleMapper> and <sourcePathToTargetMapper>#119yumaoka merged 3 commits intoIBM-Cloud:masterfrom
yumaoka merged 3 commits intoIBM-Cloud:masterfrom
Conversation
Supports new GP maven configuration parameter <pathToBundleMapper> and <sourcePathToTargetMapper> for more flexible resource file path - bundle ID mappings.
Contributor
Author
|
The coverage report does not include maven plugin test cases under |
jugu
reviewed
May 4, 2018
gp-maven-plugin/README.md
Outdated
| For each `<regexMapper>` element, substring matching a Java regular expression pattern specified by | ||
| `<pattern>` value will be replaced with the value specified by `<replacement>` value. | ||
|
|
||
| The example below will removes `.properties` from a give path, then replace `/` with `.`. |
Contributor
There was a problem hiding this comment.
typo replace removes with remove
Contributor
Author
There was a problem hiding this comment.
Done. Also from a give path with from a given path
jugu
reviewed
May 4, 2018
gp-maven-plugin/README.md
Outdated
| <sourcePathToTargetMapper> | ||
| <regexMapper> | ||
| <pattern>(.+)/en/([^/]+).json</pattern> | ||
| <replacement>$1/%LANG/$2.json</replacement> |
Contributor
Author
There was a problem hiding this comment.
Correct - I fixed above. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports new GP maven configuration parameter and
for more flexible resource file path -
bundle ID mappings.