Skip to content

Fixed Java properties file parsing problem#108

Merged
yumaoka merged 1 commit intoIBM-Cloud:masterfrom
yumaoka:bug-105-parse-props
Mar 27, 2018
Merged

Fixed Java properties file parsing problem#108
yumaoka merged 1 commit intoIBM-Cloud:masterfrom
yumaoka:bug-105-parse-props

Conversation

@yumaoka
Copy link
Contributor

@yumaoka yumaoka commented Mar 26, 2018

Fixed a Java properties file parsing problem cased by
JavaPropertiesResource#ConvertDoubleSingleQuote() when only standalone
single quote is used.

Added new resource types JAVAMSG and JAVAMSGUTF8 for supporting Java
MessageFormat pattern strings only strings, in addition to existing
JAVA/JAVAUTF8. The new types assumes resource strings are consumed by
Java MessageFormat even they do not have any arguments.

Fixed #105.

Fixed a Java properties file parsing problem cased by
JavaPropertiesResource#ConvertDoubleSingleQuote() when only standalone
single quote is used.

Added new resource types JAVAMSG and JAVAMSGUTF8 for supporting Java
MessageFormat pattern strings only strings, in addition to existing
JAVA/JAVAUTF8. The new types assumes resource strings are consumed by
Java MessageFormat even they do not have any arguments.

Fixed IBM-Cloud#105.
@yumaoka yumaoka requested a review from jugu March 26, 2018 22:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 51.101% when pulling 84ec294 on yumaoka:bug-105-parse-props into e020724 on IBM-Cloud:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 51.101% when pulling 84ec294 on yumaoka:bug-105-parse-props into e020724 on IBM-Cloud:master.

Copy link
Contributor

@jugu jugu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yumaoka yumaoka merged commit 929d4c4 into IBM-Cloud:master Mar 27, 2018
@yumaoka yumaoka deleted the bug-105-parse-props branch March 27, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants