remove pitch guidance on extract (unused)

IAHispano · Nov 1, 2024 · 95212fd · 95212fd
1 parent f9c084e
commit 95212fd
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 26 deletions.
diff --git a/core.py b/core.py
@@ -462,7 +462,6 @@ def run_extract_script(
     model_name: str,
     rvc_version: str,
     f0_method: str,
-    pitch_guidance: bool,
     hop_length: int,
     cpu_cores: int,
     gpu: int,
@@ -486,7 +485,6 @@ def run_extract_script(
                 cpu_cores,
                 gpu,
                 rvc_version,
-                pitch_guidance,
                 sample_rate,
                 embedder_model,
                 embedder_model_custom,
@@ -1937,13 +1935,6 @@ def parse_arguments():
         ],
         default="rmvpe",
     )
-    extract_parser.add_argument(
-        "--pitch_guidance",
-        type=lambda x: bool(strtobool(x)),
-        choices=[True, False],
-        help="Enable or disable pitch guidance during feature extraction.",
-        default=True,
-    )
     extract_parser.add_argument(
         "--hop_length",
         type=int,
@@ -2477,7 +2468,6 @@ def main():
                 model_name=args.model_name,
                 rvc_version=args.rvc_version,
                 f0_method=args.f0_method,
-                pitch_guidance=args.pitch_guidance,
                 hop_length=args.hop_length,
                 cpu_cores=args.cpu_cores,
                 gpu=args.gpu,

diff --git a/rvc/train/extract/extract.py b/rvc/train/extract/extract.py
@@ -247,10 +247,9 @@ def run_embedding_extraction(
     num_processes = int(sys.argv[4])
     gpus = sys.argv[5]
     version = sys.argv[6]
-    pitch_guidance = sys.argv[7]
-    sample_rate = sys.argv[8]
-    embedder_model = sys.argv[9]
-    embedder_model_custom = sys.argv[10] if len(sys.argv) > 10 else None
+    sample_rate = sys.argv[7]
+    embedder_model = sys.argv[8]
+    embedder_model_custom = sys.argv[9] if len(sys.argv) > 10 else None
 
     # prep
     wav_path = os.path.join(exp_dir, "sliced_audios_16k")
@@ -300,4 +299,4 @@ def run_embedding_extraction(
 
     # Run Preparing Files
     generate_config(version, sample_rate, exp_dir)
-    generate_filelist(pitch_guidance, exp_dir, version, sample_rate)
+    generate_filelist(exp_dir, version, sample_rate)
diff --git a/rvc/train/extract/preparing_files.py b/rvc/train/extract/preparing_files.py
@@ -16,7 +16,7 @@ def generate_config(rvc_version: str, sample_rate: int, model_path: str):
 
 
 def generate_filelist(
-    pitch_guidance: bool, model_path: str, rvc_version: str, sample_rate: int
+    model_path: str, rvc_version: str, sample_rate: int
 ):
     gt_wavs_dir = os.path.join(model_path, "sliced_audios")
     feature_dir = os.path.join(model_path, f"{rvc_version}_extracted")

diff --git a/tabs/train/train.py b/tabs/train/train.py
@@ -489,15 +489,6 @@ def train_tab():
                         label="Upload .json", type="filepath", interactive=True
                     )
                 move_files_button = gr.Button("Move files to custom embedder folder")
-        with gr.Row():
-            pitch_guidance_extract = gr.Checkbox(
-                label=i18n("Pitch Guidance"),
-                info=i18n(
-                    "By employing pitch guidance, it becomes feasible to mirror the intonation of the original voice, including its pitch. This feature is particularly valuable for singing and other scenarios where preserving the original melody or pitch pattern is essential."
-                ),
-                value=True,
-                interactive=True,
-            )
 
         with gr.Accordion(
             i18n(
@@ -550,7 +541,6 @@ def train_tab():
                 model_name,
                 rvc_version,
                 f0_method,
-                pitch_guidance_extract,
                 hop_length,
                 cpu_cores_extract,
                 gpu_extract,