Add instance_id_prefix in AWS, Azure, and GCP#1786
Merged
abuabraham-ttd merged 11 commits intomainfrom Jun 6, 2025
Merged
Conversation
abuabraham-ttd
force-pushed
the
abu-UID2-5596
branch
from
61f6738 to
5c192ca
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-5596
branch
from
6a78db6 to
281e023
Compare
abuabraham-ttd
force-pushed
the
abu-UID2-5596
branch
from
bf93326 to
552a501
Compare
asloobq
reviewed
Jun 5, 2025
Contributor
asloobq
left a comment
asloobq
left a comment
There was a problem hiding this comment.
1 question on a hardcoded IP address. Otherwise LGTM
| class GCPEntryPoint(ConfidentialCompute): | ||
|
|
||
| class AuxiliaryConfig: | ||
| GCP_METADATA: str = "169.254.169.254" |
Contributor
There was a problem hiding this comment.
what does this hardcoded IP address refer to ?
Contributor
Author
There was a problem hiding this comment.
This is the instance metadata endpoint. It is static 169.254.169.254 and local to instance (link local IP range). AWS, GCP both provides this and it returns instance metadata (region, instance-id, image used etc)
cYKatherine
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/IABTechLab/uid2-operator/actions/runs/15474269414
Successful E2E.
Changes