Fix manager state observation and associated tests#55
Merged
Conversation
dcaunt
force-pushed
the
dave/fix-manager-observation
branch
from
fb99e22 to
8e8ceba
Compare
mrmans0n
approved these changes
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After fixing the flaky test, it was clear that there was also a bug in the state observation stream. By capturing
self.state, it was not evaluated until the enqueued operation actually executed, but we need to capture the value ofstateat the time of enqueuing.Test failure rate was previously somewhere between 10% and 25% of runs. I've left the tests running on a loop and I'm confident they are no longer flaky.