Conversation
mrmans0n
approved these changes
Aug 1, 2024
mrmans0n
left a comment
mrmans0n
left a comment
There was a problem hiding this comment.
Do we need to relax a bit the linting about max lines?
Collaborator
Author
Yeah, I'll follow up when I've taken a look at all the Swiftlint rules. I need to disable the false positive's for UTF-8 data too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model identity, or 'manager state', using a single value (Android SDK already does this) and add conveniences for deriving/extracting the token identity and status. This will allow callers to observe a single value (follow-up PR) and lets us tighten up some internal code by no longer modelling invalid states.