Conversation
mrmans0n
reviewed
Jul 18, 2024
| @testable import UID2 | ||
|
|
||
| // Simple Atomic implementation for test usage | ||
| private final class Atomic<Value: Sendable>: @unchecked Sendable { |
There was a problem hiding this comment.
should these different classes in this file be in their own files?
Collaborator
Author
There was a problem hiding this comment.
No hard and fast rule, but the usage here is quirky and while required to capture the symmetric key, shouldnt be encouraged elsewhere in favor of Swift's stronger concurrency mechanisms, so I'm inclined to keep it private.
mrmans0n
approved these changes
Jul 18, 2024
IanDBird
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UID2Managerinitializer for testing