Skip to content

Ensure sample sites are correctly and consistently named#52

Merged
eiman-eltigani-ttd merged 32 commits intomainfrom
eee-UID2-4825-ensure-accurate-sample-site-titles-within-repo
Oct 23, 2025
Merged

Ensure sample sites are correctly and consistently named#52
eiman-eltigani-ttd merged 32 commits intomainfrom
eee-UID2-4825-ensure-accurate-sample-site-titles-within-repo

Conversation

@eiman-eltigani-ttd
Copy link

@eiman-eltigani-ttd eiman-eltigani-ttd commented Oct 22, 2025

Summary of changes:

  • Standardized name across alll sample sites for consistent formatting
  • Updated UI Titles and all instances across html files and readmes
  • For pages with multiple html files, I hypenated the the name of the document so each title is unique

@eiman-eltigani-ttd eiman-eltigani-ttd marked this pull request as ready for review October 22, 2025 22:18
<head>
<meta charset="UTF-8" />
<title>Error</title>
<title>Client-Server UID2 SDK Integration Example with Google Secure Signals - Error</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo the word that denotes the type of page like "Error", "Optout" etc. should come first (and maybe even bolded) so it stands out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated but since these tags arent actually displayed on the page, I cant change the style or anything

@ashleysmithTTD
Copy link
Contributor

ashleysmithTTD commented Oct 23, 2025

the folder for uid2-examples/publisher/server_only should probably be moved and renamed. it technically does not use the javascript-sdk so maybe it should be in uid2-examples/web-integrations/server-side. This is a site without a copy though, so either we can make a copy and delete the old one later, or we need to update the docs repo with the code reference

@ashleysmithTTD
Copy link
Contributor

/google-secure-signals/server-side/views/header.html needs an updated source code linkl

@eiman-eltigani-ttd
Copy link
Author

the folder for uid2-examples/publisher/server_only should probably be moved and renamed. it technically does not use the javascript-sdk so maybe it should be in uid2-examples/web-integrations/server-side. This is a site without a copy though, so either we can make a copy and delete the old one later, or we need to update the docs repo with the code reference

I made a copy and added to the dockerfile configuration. I rather wait to update all the links since we'll be replacing them all anyway

@eiman-eltigani-ttd eiman-eltigani-ttd force-pushed the eee-UID2-4825-ensure-accurate-sample-site-titles-within-repo branch from 25859d9 to a1414f5 Compare October 23, 2025 18:43
@eiman-eltigani-ttd eiman-eltigani-ttd merged commit b1df209 into main Oct 23, 2025
2 checks passed
@eiman-eltigani-ttd eiman-eltigani-ttd deleted the eee-UID2-4825-ensure-accurate-sample-site-titles-within-repo branch October 23, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants