In case the macAddres is nos available, at least take the username trying to identify the user/machine

[albertmena]

No description provided.

[MartinSalinas98]

I'm not sure I agree with this approach. Getting the username of a machine has some privacy concerns asociated. I think it would be better to leave it at "Anonymous" in such case instead of returning a username.

[albertmena]

I'm not sure I agree with this approach. Getting the username of a machine has some privacy concerns asociated. I think it would be better to leave it at "Anonymous" in such case instead of returning a username.

We dont collect the userName because we hasheasmos. The code tries to manage the machines that we can not collect the macAddres but we need a ID (trying to avoid a lot of anonymous that we handle as just one user)

[MartinSalinas98]

Same as previous comment, only one condition.

Also: why "Unknown"? Now we have both "Anonymous" and "Unknown", i'd stick to only having one of them.

[MartinSalinas98]

Edit 2: In case unknown is left, there is a typo, "UnknowN"

[albertmena]

Because we can hunt more casuistic.
Anonymous for users that havent macAddres
Unknown for users without macAddres and without username.

[MartinSalinas98]

But I don't really see the point of having a unique hashed id for non-existing mac address and non-existing username:
The way it is now:

1. mac == None --> mac = "Anonymous"
2. user == None --> user = "Unknown"
3. identifier = mac + user = "AnonymousUnknown"
4. hash(identifier) = 3719hd01ncbuebvn09d1m
   So, users with no username and no mac address won't show up as "Anonymous" or "Unknown", but instead with a non human-readable id resulting on the hash.

On the other hand:

1. mac == "ff:ff:ff" --> mac = "ff:ff:ff"
2. user == myuser --> user = "myuser"
3. identifier = "ff:ff:ffmyuser"
4. hash(identifier) = tevcbijsncaosnu183802cnjc
   With this code, two users in the same machine will have different ids.

I'd suggest to only get the username when no mac address is found, and return "Anonymous", if neither of them exists. So:

1. If mac address exists, only use mac adress
2. If mac address dos not exist, only use username
3. If none exist, return "Anonymous"

[MartinSalinas98]

By the way. Insead of doing:

status, output = runJobe("whoami")
if status == 0:
  return output

You could just:

import getpass
return getpass.getuser()

It is standard Python library, no need to install anything else, and it works in mostly all OSs.
https://docs.python.org/3.8/library/getpass.html

Or even if you want it to work on ALL OSs, you can just:

try:
    return getpass.getuser()
except KeyError, OSError: # From Python >= 3.13, only OSError can be returned, so KeyError could be removed
    return "Anonymous"

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[albertmena]

Lets wait until we collect more details about the installations and the possible errors in the posting