Skip to content

Commit

Permalink
[SPARK-48280][SQL] Improve collation testing surface area using expre…
Browse files Browse the repository at this point in the history
…ssion walking

### What changes were proposed in this pull request?
This PR is introducing Expression Walker in different forms in order to improve collation testing surface area. The tests added include:

1. Expression Walker for expression evaluation
2. Expression Walker for SQL query examples
3. Expression Walker for codeGen generation

### Why are the changes needed?
Collations introduced a lot of changes to many functions and parts of the code and these tests aim to catch existing errors and prevent addition of new functions without proper implementation of collation support.
To emphasise the importance of these tests, some of the relevant tickets that were opened as a byproduct of this testing:

- https://issues.apache.org/jira/browse/SPARK-48472
- https://issues.apache.org/jira/browse/SPARK-48572
- https://issues.apache.org/jira/browse/SPARK-48574
- https://issues.apache.org/jira/browse/SPARK-48600
- https://issues.apache.org/jira/browse/SPARK-48662

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
This PR is only related to testing.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#46801 from mihailom-db/SPARK-48280.

Authored-by: Mihailo Milosevic <mihailo.milosevic@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
  • Loading branch information
mihailom-db authored and cloud-fan committed Jul 4, 2024
1 parent bf25f0a commit d5dc223
Showing 1 changed file with 647 additions and 0 deletions.
Loading

0 comments on commit d5dc223

Please sign in to comment.