Skip to content

Commit

Permalink
[SPARK-48425][PYTHON][BUILD] Replaces pyspark-connect to pyspark_conn…
Browse files Browse the repository at this point in the history
…ect for its output name

### What changes were proposed in this pull request?

This PR proposes to replace `pyspark-connect` to `pyspark_connect` for its output name.

### Why are the changes needed?

`setuptools` from 69.X.X changes the output name. It replaces dash in package name to underscore (`pyspark_connect-4.0.0.dev1.tar.gz` vs `pyspark-connect-4.0.0.dev1.tar.gz`), I think it is pypa/setuptools#4214.

### Does this PR introduce _any_ user-facing change?

No, this package has not been released out yet.

### How was this patch tested?

Manually tested.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46751 from HyukjinKwon/SPARK-48425.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
  • Loading branch information
HyukjinKwon committed May 27, 2024
1 parent 4ef5ec9 commit 8f678a4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions dev/create-release/release-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,12 @@ if [[ "$1" == "finalize" ]]; then
--repository-url https://upload.pypi.org/legacy/ \
"pyspark-$RELEASE_VERSION.tar.gz" \
"pyspark-$RELEASE_VERSION.tar.gz.asc"
svn update "pyspark-connect-$RELEASE_VERSION.tar.gz"
svn update "pyspark-connect-$RELEASE_VERSION.tar.gz.asc"
svn update "pyspark_connect-$RELEASE_VERSION.tar.gz"
svn update "pyspark_connect-$RELEASE_VERSION.tar.gz.asc"
TWINE_USERNAME=spark-upload TWINE_PASSWORD="$PYPI_PASSWORD" twine upload \
--repository-url https://upload.pypi.org/legacy/ \
"pyspark-connect-$RELEASE_VERSION.tar.gz" \
"pyspark-connect-$RELEASE_VERSION.tar.gz.asc"
"pyspark_connect-$RELEASE_VERSION.tar.gz" \
"pyspark_connect-$RELEASE_VERSION.tar.gz.asc"
cd ..
rm -rf svn-spark
echo "PySpark uploaded"
Expand Down Expand Up @@ -314,7 +314,7 @@ if [[ "$1" == "package" ]]; then
--detach-sig $PYTHON_DIST_NAME
shasum -a 512 $PYTHON_DIST_NAME > $PYTHON_DIST_NAME.sha512

PYTHON_CONNECT_DIST_NAME=pyspark-connect-$PYSPARK_VERSION.tar.gz
PYTHON_CONNECT_DIST_NAME=pyspark_connect-$PYSPARK_VERSION.tar.gz
cp spark-$SPARK_VERSION-bin-$NAME/python/dist/$PYTHON_CONNECT_DIST_NAME .

echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour \
Expand Down

0 comments on commit 8f678a4

Please sign in to comment.