Further typing upgrades for Python 3.9 #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
py39-type-hints
branch
from
ea06d1d
to
e2fecca
Compare
Zac-HD
force-pushed
the
py39-type-hints
branch
2 times, most recently
from
d8c14c0
to
bd58995
Compare
Zac-HD
force-pushed
the
py39-type-hints
branch
from
bd58995
to
f4d66f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for next year: if you're not upgrading
shedat the same time, you need to runFORMAT_ALL=true make formatto get all the files. So here's the remainder.Along with the syntax update, I've deleted some redundant tests for
typing_extensions.Annotated, since that's simply a re-export of the stdlib class on Python 3.9+