Skip to content

Add methods for accessing skyblock/profiles endpoint #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2021
Merged

Add methods for accessing skyblock/profiles endpoint #297

merged 5 commits into from
Jul 26, 2021

Conversation

q-256
Copy link
Contributor

@q-256 q-256 commented Aug 14, 2020 •
edited
Loading

Just a few basic methods for accessing the endpoint.

@ConnorLinfoot ConnorLinfoot added this to the v4.0.0 milestone May 9, 2021
ConnorLinfoot
ConnorLinfoot approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@ConnorLinfoot ConnorLinfoot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the method name which I've changed, otherwise looks good. We'll be looking to include this with the 4.0.0 release, hopefully sometime this month.

CyberFlameGO
CyberFlameGO approved these changes Jul 4, 2021
View reviewed changes
Copy link

@CyberFlameGO CyberFlameGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Adding methods to access that endpoint seems like it’ll prove useful to developers

@ConnorLinfoot ConnorLinfoot merged commit 59f2597 into HypixelDev:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorLinfoot ConnorLinfoot ConnorLinfoot approved these changes

@CyberFlameGO CyberFlameGO CyberFlameGO approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@q-256 @ConnorLinfoot @CyberFlameGO