Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new reference #2

Closed
6 tasks done
SebBac opened this issue Feb 28, 2023 · 10 comments
Closed
6 tasks done

Add new reference #2

SebBac opened this issue Feb 28, 2023 · 10 comments
Assignees
@PaulGitProject @koeltv @Anto792 @AliceGuib @AgatheIV @khbgbgk1
Labels
feature

Comments

@SebBac
Copy link
Contributor

SebBac commented Feb 28, 2023 •
edited by AgatheIV
Loading

En tant qu’utilisateur, depuis une page, je souhaite pouvoir ajouter de nouvelles références vers d’autres documents.

Critères d’acceptations : depuis un document, je peux rajouter et enregistrer de nouvelles références.

Exemple de référence :
image

Phase 1

  • Scenarios (Gherkin)
  • Mockups
  • Implementation strategy

Phase 2

  • Acceptance tests (Capybara)
  • Implementation

Phase 3

  • Screencast
@SebBac SebBac changed the title Edit reference Add new reference Feb 28, 2023
@AmalCHIKHAOUI
Copy link
Contributor

AmalCHIKHAOUI commented Feb 28, 2023 •
edited
Loading

Juste de titre c'est pas clair ou il faut rajouter la référence ou elle sert quoi, ça respecte pas le critère de négociation

@benel
Copy link
Member

benel commented Mar 13, 2023

@SebBac Le titre est peut-être suffisant, mais dans la description, il faudrait peut-être préciser ce que vous entendez par "référence".

@benel benel added the feature label Mar 13, 2023
@benel benel mentioned this issue Mar 14, 2023
Open
@lililiane
Copy link
Contributor

Art plastique : cette feature peut être utilisé pour ajouter la référence d'un dessin/tableau dans une collection/exposition

@Ziwei-GONG-UTT Ziwei-GONG-UTT moved this to Suggéré in Arts plastiques 2023 Mar 14, 2023
@vallhallalm vallhallalm moved this to Suggéré in Histoire de l'art 2023 Mar 16, 2023
@MCtzr
Copy link
Contributor

MCtzr commented Mar 16, 2023

Histoire de l'art : Cette feature pourrait être intéressante pour notre projet. Cependant, celle-ci ne semble pas être une priorité. Notre partie prenante étant informaticien, ajouter des références à partir du Json ne lui posera peut être pas problème.

@MCtzr MCtzr mentioned this issue Mar 16, 2023
Closed
@RomainUTT
Copy link
Contributor

Ethnométhodologie: This can be helpful to link our actions.

@RomainUTT RomainUTT moved this to Suggéré in Ethnographie 2023 Mar 17, 2023
@julien-millour julien-millour moved this from Suggéré to À faire in Ethnographie 2023 Mar 24, 2023
@lililiane lililiane moved this from Suggéré to À faire in Arts plastiques 2023 Mar 28, 2023
@vallhallalm vallhallalm moved this to Suggéré in Histoire de l'art 2023 Mar 30, 2023
@lililiane lililiane moved this from À faire to Suggéré in Arts plastiques 2023 Jun 21, 2023
@github-project-automation github-project-automation bot moved this to Suggéré in Traduction 2024 Apr 16, 2024
@koeltv koeltv moved this from Suggéré to À faire in Traduction 2024 Apr 16, 2024
@koeltv koeltv moved this from À faire to En cours in Traduction 2024 Apr 16, 2024
@khbgbgk1 khbgbgk1 self-assigned this Apr 16, 2024
@koeltv koeltv self-assigned this Apr 16, 2024
@AgatheIV AgatheIV self-assigned this Apr 16, 2024
@Anto792 Anto792 self-assigned this Apr 16, 2024
@AliceGuib AliceGuib self-assigned this Apr 16, 2024
@Anto792 Anto792 assigned khbgbgk1 and Anto792 and unassigned AliceGuib Apr 16, 2024
@AliceGuib AliceGuib self-assigned this Apr 16, 2024
@khbgbgk1
Copy link
Contributor

khbgbgk1 commented Apr 16, 2024 •
edited by koeltv
Loading

Préparation de l'implémentation:
ça touchera :

  • au DocumentsCards: remettre visible possibilité de faire un +
  • au FutureDocument : créer un nouveau composant à l'image de "FutureDocument"

Avec @koeltv

@PaulGitProject
Copy link
Contributor

Traduction 2024
Maquette avec @Anto792 et @PaulGitProject sur Figma

Seconde possibilité :
Prototype Figma

Screenshots :

Image

Image

@Anto792
Copy link
Contributor

Anto792 commented Apr 16, 2024

Projet traduction 2024
Maquette avec @PaulGitProject et @Anto792
Première version
image
image
image

PaulGitProject added a commit that referenced this issue Apr 30, 2024
@AgatheIV @AliceGuib
@PaulGitProject @khbgbgk1
SCENARIO: Add a reference to a document (see #2).
e8597a2 
Co-authored-by: AliceGuib <alice.guibereau@utt.fr>
Co-authored-by: PaulGitProject <29106016+PaulGitProject@users.noreply.github.com>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
PaulGitProject added a commit that referenced this issue Apr 30, 2024
@PaulGitProject @AgatheIV @khbgbgk1
TEST: Add new reference (see #2).
d6dc30d 
Co-authored-by: AgatheIV <agathe.guichard@utt.fr>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
koeltv added a commit that referenced this issue Apr 30, 2024
@koeltv @khbgbgk1
FEATURE: Add new reference (closes #2).
26cea41 
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
koeltv added a commit that referenced this issue Apr 30, 2024
@AgatheIV @AliceGuib
@PaulGitProject @khbgbgk1 @koeltv
SCENARIO: Add a reference to a document (see #2).
5cff915 
Co-authored-by: AliceGuib <alice.guibereau@utt.fr>
Co-authored-by: PaulGitProject <29106016+PaulGitProject@users.noreply.github.com>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
koeltv added a commit that referenced this issue Apr 30, 2024
@PaulGitProject @AgatheIV
@khbgbgk1 @koeltv
TEST: Add new reference (see #2).
2da038d 
Co-authored-by: AgatheIV <agathe.guichard@utt.fr>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
koeltv added a commit that referenced this issue Apr 30, 2024
@koeltv @khbgbgk1
FEATURE: Add new reference (closes #2).
a72d992 
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
@koeltv
Copy link
Contributor

koeltv commented Apr 30, 2024 •
edited
Loading

Quelques problèmes pour les tests, en effet l'ajout d'un nouveau bouton avec la classe 'create-document' rend certains tests ambigus, aussi des modifications ont du être appliqué du côté de Capybara pour les différencier.
Cependant il existait déjà une ambiguité entre le bouton sur la page d'accueil et celui sur le lectern qui n'avait aucun impact jusqu'ici ceux-ci étant sur des pages différentes, mais l'apparition d'un 3ème bouton nécessitait de faire la différence dans certains cas.

Schéma de mise à jour des commits:
git stash > git reset hard SCENARIO > git unstash > git amend > git cherry-pick TEST > git unstash > git amend > git cherry-pick FEATURE > git push --force

@koeltv koeltv moved this from En cours to En intégration in Traduction 2024 Apr 30, 2024
@koeltv koeltv mentioned this issue May 7, 2024
Closed
6 tasks
benel pushed a commit that referenced this issue May 8, 2024
@AgatheIV @AliceGuib
@PaulGitProject @khbgbgk1 @koeltv @benel
SCENARIO: Add a reference to a document (see #2).
49cdf0d 
Co-authored-by: AliceGuib <alice.guibereau@utt.fr>
Co-authored-by: PaulGitProject <29106016+PaulGitProject@users.noreply.github.com>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
benel pushed a commit that referenced this issue May 8, 2024
@PaulGitProject @AgatheIV
@khbgbgk1 @koeltv @benel
TEST: Add a reference to a document (see #2).
d166fc9 
Co-authored-by: AgatheIV <agathe.guichard@utt.fr>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
benel pushed a commit that referenced this issue May 8, 2024
@koeltv @khbgbgk1 @benel
FEATURE: Add a reference to a document (closes #2).
fa4a759 
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
benel pushed a commit that referenced this issue May 8, 2024
@AgatheIV @AliceGuib
@PaulGitProject @khbgbgk1 @koeltv @benel
SCENARIO: Add a reference to a document (see #2).
710606c 
Co-authored-by: AliceGuib <alice.guibereau@utt.fr>
Co-authored-by: PaulGitProject <29106016+PaulGitProject@users.noreply.github.com>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
benel pushed a commit that referenced this issue May 8, 2024
@PaulGitProject @AgatheIV
@khbgbgk1 @koeltv @benel
TEST: Add a reference to a document (see #2).
9f426ba 
Co-authored-by: AgatheIV <agathe.guichard@utt.fr>
Co-authored-by: khbgbgk1 <thibault.bisagni@utt.fr>
Co-authored-by: koeltv <valentin.koeltgen@utt.fr>
@benel benel closed this as completed in 3a61483 May 8, 2024
@github-project-automation github-project-automation bot moved this from En intégration to Fait in Traduction 2024 May 8, 2024
@AgatheIV
Copy link
Contributor

AgatheIV commented Jun 4, 2024

https://github.com/Hypertopic/HyperGlosae/assets/119731198/6cdfb4ab-3481-410f-bdbe-2a5d1638be5e
Screencast de la fonctionalité réalisé par @PaulGitProject et moi même

benel added a commit that referenced this issue Aug 11, 2024
@benel
REFACTORING: Feature #2 is no more necessary.
6a74f71 
Use cases of feature #2 are subsumed by feature #219 and, moreover, 
feature #2 had several drawbacks:

- it edited the focused document (which is not coherent with the UI),
- it did not prevent an uneditable document to be chosen,
- it did not allow to choose the link type as in feature #201.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulGitProject PaulGitProject

@koeltv koeltv

@Anto792 Anto792

@AliceGuib AliceGuib

@AgatheIV AgatheIV

@khbgbgk1 khbgbgk1

Labels
feature
Projects
No open projects
Arts plastiques 2023
Status: Suggéré
Ethnographie 2023
Status: À faire
Histoire de l'art 2023
Status: Suggéré
Histoire du cinéma 2023
Status: Suggéré
Traduction 2024
Status: Fait
Milestone
No milestone
Development

No branches or pull requests