Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete a picture from a document #187

Open
petitfa1 opened this issue May 29, 2024 · 5 comments · May be fixed by #210
Open

Delete a picture from a document #187

petitfa1 opened this issue May 29, 2024 · 5 comments · May be fixed by #210
Labels

Comments

@petitfa1
Copy link
Contributor

petitfa1 commented May 29, 2024

Linked to the feature #153 , for now it's possible to add a picture into a document, but not to delete it.

The idea would be to add a button on each picture allowing the user to delete it from the server.

@petitfa1
Copy link
Contributor Author

petitfa1 commented May 29, 2024

Phase 1

  • Scenarios (Gherkin)
  • Mockups
  • Implementation strategy

Phase 2

  • Acceptance tests (Capybara)
  • Implementation

Phase 3

  • Screencast

@louisduhalberruer
Copy link
Contributor

louisduhalberruer commented Jun 7, 2024

Implementation strategy :

  • We looked at how to DELETE attachments from CouchDB using http client such as Postman
  • With this knowledge, we can now implement the UI for deleting pictures, which consists in :
    • adding a delete button on every image, with a confirmation dialog when pressed
    • then making the correct API call to delete an attachment
    • refresh the ui

@Hypertopic Hypertopic deleted a comment from Barnabepetit Jun 12, 2024
@raphaelweis
Copy link
Contributor

raphaelweis commented Jun 12, 2024

Frame 4

Frame 5(1)

Binôme @raphaelweis et @Barnabepetit.

@raphaelweis
Copy link
Contributor

The mockups have been updated because the previous proposition did not allow for multiple images to be in the same block.

nitram35 added a commit that referenced this issue Jun 12, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
nitram35 added a commit that referenced this issue Jun 12, 2024
Co-Authored-By: Fabien Petit<petifa1@users.noreply.github.com>
@benel
Copy link
Member

benel commented Jun 15, 2024

@nitram35 and @petitfa1, don't forget to open a draft pull request on your branch (even if is not finished, so that I can review your code).

@nitram35 nitram35 linked a pull request Jun 16, 2024 that will close this issue
petitfa1 added a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Martin GANDOM<nitram35@users.noreply.github.com>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <louisduhalberruer@users.noreply.github.com>
nitram35 added a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit<petifa1@users.noreply.github.com>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <louisduhalberruer@users.noreply.github.com>
nitram35 added a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit<petifa1@users.noreply.github.com>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <louisduhalberruer@users.noreply.github.com>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <louisduhalberruer@users.noreply.github.com>
raphaelweis pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <louisduhalberruer@users.noreply.github.com>
raphaelweis pushed a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit<petifa1@users.noreply.github.com>
nitram35 added a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit <fabien.petit@users.noreply.github.com>
nitram35 added a commit that referenced this issue Jun 19, 2024
Co-Authored-By: Fabien Petit<petifa1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants