Java import #12
Merged
Java import #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related with Hyperledger-TWGC/java-gm#23 |
SamYuan1990
force-pushed
the
javaImport
branch
from
12d6b66
to
e7a8341
Compare
SamYuan1990
force-pushed
the
javaImport
branch
from
e7a8341
to
aec78ce
Compare
davidkhala
reviewed
Feb 5, 2021
davidkhala
reviewed
Feb 5, 2021
SamYuan1990
force-pushed
the
javaImport
branch
from
ae502e0
to
3df39ef
Compare
|
@davidkhala, cloud you pls help with this pr? |
SamYuan1990
force-pushed
the
javaImport
branch
from
3df39ef
to
a0165fb
Compare
|
@SamYuan1990 Oops, it conflicts with branch due to another PR merged. Would you mind make alignment? |
Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990
force-pushed
the
javaImport
branch
from
a0165fb
to
b714ea1
Compare
fix for Hyperledger-TWGC#8 Signed-off-by: SamYuan1990 <yy19902439@126.com>
SamYuan1990
force-pushed
the
javaImport
branch
from
b714ea1
to
ded2c32
Compare
rebased to latest. |
davidkhala
reviewed
Feb 10, 2021
| @@ -15,4 +17,24 @@ func TestTJSM2Pem(t *testing.T) { | |||
| var pemFile = "testdata/privateKey.tjfoc.pem" | |||
| WriteFile(pemBytes, pemFile, t) | |||
There was a problem hiding this comment.
这里为什么要重复写两次来着？privateKey.tjfoc.pem这个文件名不适合么？
There was a problem hiding this comment.
en, java gm 里没用这个文件名。 不是很想用cp实现。（因为现在java-gm是看文件检测的关系，所以一旦cp被误删，就会导致互操作验证的机制丢失。）
There was a problem hiding this comment.
我猜也是节省cp操作的原因，先merge了吧，我之后来做一个繁琐点的cp
davidkhala
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #8