Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkboxes and radio buttons broken #4

Closed
mehaase opened this issue Jul 12, 2019 · 1 comment
Closed

Checkboxes and radio buttons broken #4

mehaase opened this issue Jul 12, 2019 · 1 comment

Comments

@mehaase
Copy link
Contributor

mehaase commented Jul 12, 2019

Seen here: https://hyperiongray.github.io/ng_modular_admin_demo/#/forms

Screenshot from 2019-07-12 14-29-53
@mehaase
Copy link
Contributor Author

mehaase commented Mar 17, 2020

This was originally implemented using the CSS pseudo-element ::after on the <input> element, but it appears that this is not actually allowed: https://stackoverflow.com/a/4660434/122763. So this might be something that works in some browsers but not others, or it might be something that was permitted in older browsers but is now prohibited.

In any case, the solution is to move the pseudo-element to the label. But this requires changing the markup for the input groups since the styles on the label now need to be conditional on the state of the input.

mehaase added a commit that referenced this issue Mar 17, 2020
@mehaase
Checkboxes and radio buttons broken #4
3f8bf34 
The way there were implemented before appears to be invalid with respect
to the CSS3 spec. This new implementation moves the ::after pseudo
element from the <input> to the <label> but that requires quite a bit of
change to the CSS and also to the markup itself.
@mehaase mehaase closed this as completed Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mehaase