Conversation
![managerbot-app[bot]](https://avatars.githubusercontent.com/in/853044?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed Changes
Managerbot reviewed 2 out of 9 changed files in this pull request and generated 23 comments.
Files not reviewed (7)
- .DS_Store
- _layouts/default.html
- assets/images/chart-leadtime@2x.png
- assets/images/img-non-linear-mobile@2x.png
- assets/images/img-non-linear@2x.png
- assets/images/masthead-img@2x.png
- index.html
Comments suppressed due to low confidence (0)
| // <weight>: Use a value from 200 to 800 | ||
| // <uniquifier>: Use a unique and descriptive class name | ||
|
|
||
| .bricolage-grotesque-<uniquifier> { |
There was a problem hiding this comment.
The class .bricolage-grotesque-<uniquifier> contains placeholders that need to be replaced with actual values before use.
| .bricolage-grotesque-<uniquifier> { | ||
| font-family: "Bricolage Grotesque", sans-serif; | ||
| font-optical-sizing: auto; | ||
| font-weight: <weight>; |
There was a problem hiding this comment.
The <weight> placeholder needs to be replaced with an actual font weight value between 200 and 800.
| } | ||
|
|
||
| .hero { | ||
| flex-direction: row !important; |
There was a problem hiding this comment.
Avoid using !important unless absolutely necessary. It makes CSS harder to maintain and override.
| flex-direction: row !important; | ||
| } | ||
| .content { | ||
| text-align:left; |
There was a problem hiding this comment.
Missing space after colon in text-align:left;. Follow consistent spacing in CSS properties.
| } | ||
| .content { | ||
| text-align:left; | ||
| max-width:500px; |
There was a problem hiding this comment.
Missing space after colon in max-width:500px;. Maintain consistent formatting.
| } | ||
|
|
||
| .full-width-layout__content { | ||
| margin:0 !important; |
There was a problem hiding this comment.
Missing space after colon in margin:0 and avoid using !important.
|
|
||
| .full-width-layout__content { | ||
| margin:0 !important; | ||
| align-items:center; |
There was a problem hiding this comment.
Missing space after colon in align-items:center;.
| } | ||
|
|
||
| .old-way .full-width-layout__content p { | ||
| max-width: var(--old-way-copy-max-width, 80%) !important; |
There was a problem hiding this comment.
Avoid using !important in selectors. Consider restructuring CSS to achieve the same result without it.
| } | ||
|
|
||
| .old-way img { | ||
| margin-top: var(--old-way-image-margin, 30px) !important; |
There was a problem hiding this comment.
Avoid using !important in margin-top: var(--old-way-image-margin, 30px) !important;.
| } | ||
|
|
||
| .text-gradient { | ||
| background: -webkit-linear-gradient(0deg, #FEBA01, #F22089); |
There was a problem hiding this comment.
Use standard CSS gradient syntax with vendor prefixes or consider using modern unprefixed gradients with fallbacks.
1 participant
wip