fix: ensure git diff output is properly encoded as UTF-8#27
Merged
billybonks merged 1 commit intoHyper-Unearthing:masterfrom Mar 25, 2025
Merged
fix: ensure git diff output is properly encoded as UTF-8#27billybonks merged 1 commit intoHyper-Unearthing:masterfrom
billybonks merged 1 commit intoHyper-Unearthing:masterfrom
Conversation
![managerbot-app[bot]](https://avatars.githubusercontent.com/in/853044?s=60&v=4){kind=small}
milarze
force-pushed
the
master
branch
2 times, most recently
from
48bd7da to
1db5df4
Compare
billybonks
requested changes
Mar 25, 2025
| require 'committer/commit_generator' | ||
|
|
||
| RSpec.describe Committer::CommitGenerator do | ||
| let(:diff) { load_fixture('sample_diff.txt') } |
Contributor
There was a problem hiding this comment.
i think sample diff is only used here so if you removed it we can delete the file
burn: Remove unused fixture
billybonks
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26