feat: Added ability to use other clients in the future#21
Merged
billybonks merged 2 commits intoHyper-Unearthing:masterfrom Mar 11, 2025
Merged
feat: Added ability to use other clients in the future#21billybonks merged 2 commits intoHyper-Unearthing:masterfrom
billybonks merged 2 commits intoHyper-Unearthing:masterfrom
Conversation
![managerbot-app[bot]](https://avatars.githubusercontent.com/in/853044?s=60&v=4){kind=small}
billybonks
approved these changes
Mar 11, 2025
Contributor
billybonks
left a comment
billybonks
left a comment
There was a problem hiding this comment.
Looks, good given that you are just testing that a custom client be added and is used i think that is good enough :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added dep injection so in the future, other clients can be added 👍
Not sure if the tests are robust enough but I imagine if there is a different client, there would be client specific integration tests to cover it?