Skip to content

Replace formatting rules file loading with config accessor #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billybonks merged 1 commit into from
Mar 8, 2025
Merged

Replace formatting rules file loading with config accessor #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/committer/prompt_templates.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@

module Committer
module PromptTemplates
FORMATTING_RULES_PATH = File.join(File.dirname(__FILE__), 'formatting_rules.txt')

def self.load_formatting_rules
File.read(FORMATTING_RULES_PATH)
Committer::Config::Accessor.instance.load_formatting_rules
Copy link

@managerbot-app managerbot-app bot Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a dependency on the Committer::Config::Accessor singleton. Consider if this is the appropriate design pattern or if dependency injection would be more maintainable and testable.

end

def self.load_scopes
Expand Down
Loading