Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme/setup.py: python <3.13 because of audioop #93

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

afeistel
Copy link
Contributor

audioop got removed in Python 3.13, so import hata fails on 3.13;
on 3.12, seems to, at least, import fine

@afeistel
Copy link
Contributor Author

I assume later audioop should probably be replaced with something else but for now this at least clarifies it doesn't support 3.13

@HuyaneMatsu
Copy link
Owner

Python 3.12 is not fully supported yet either, because of the new f-string syntax is not fully implemented in expression boundary parsing. I know its not mentioned in the setup file, but the dependencies have it mentioned.

Sadly pip does not care about supported python versions (& operation systems) and lets the installation pass.

So setting < 3.12 would match the requirements better. <3

@afeistel
Copy link
Contributor Author

afeistel commented Mar 22, 2025

okay then that also covers SyntaxWarnings for now, since those start with 3.12

(the ones about \_ and \:, mostly)

@afeistel
Copy link
Contributor Author

pip does not care about supported python versions

I'm using uv, and that thing cares quite a lot about Python versions, so at least there it matters

@HuyaneMatsu
Copy link
Owner

Yes. I once fixed those issues, but seems like some escaped if you got them.
At that time, I researched the SyntaxWarning in the "whats new", and it turned out that it is already a thing since 3.6, but some bug(?) prevented them being displayed.

I will try to go through the SyntaxWarning again, thanks for finding them.

@HuyaneMatsu HuyaneMatsu merged commit 092dad2 into HuyaneMatsu:master Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants