Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ja-JP for Number to Word #981

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Implement ja-JP for Number to Word #981

merged 4 commits into from
Sep 30, 2020
+155 −4

Conversation

Hee-San
Copy link
Contributor

@Hee-San Hee-San commented Sep 24, 2020

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings — no can do, I'm on macOS
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change — not really
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below) — there's no dev branch in origin.
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one — not applicable
  • Run either build.cmd or build.ps1 and ensure there are no test failures — no can do, I'm on macOS

fixes #980

@dnfadmin
Copy link

dnfadmin commented Sep 24, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

clairernovotny
clairernovotny requested changes Sep 26, 2020
View reviewed changes
Copy link
Member

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the two changes

src/Humanizer.Tests.Shared/Humanizer.Tests.Shared.shproj Outdated
@@ -9,7 +9,7 @@
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.Common.props" />
<PropertyGroup />
<ItemGroup>
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
<Service Include="$(MSBuildThisFileDirectory){82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at c207cb0.

src/Humanizer.Tests.Shared/Humanizer.Tests.Shared.projitems Outdated
@@ -190,5 +190,6 @@
<Compile Include="$(MSBuildThisFileDirectory)TransformersTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)TruncatorTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCultureAttribute.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Localisation\ja\NumberToWordsTests.cs" Condition=" '$(EnableDefaultCompileItems)' == 'true' " />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Compile Include="$(MSBuildThisFileDirectory)Localisation\ja\NumberToWordsTests.cs" Condition=" '$(EnableDefaultCompileItems)' == 'true' " />
<Compile Include="$(MSBuildThisFileDirectory)Localisation\ja\NumberToWordsTests.cs" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at c207cb0.

@clairernovotny clairernovotny merged commit 8054572 into Humanizr:master Sep 30, 2020
@clairernovotny
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairernovotny clairernovotny clairernovotny requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Japanese Number to Word doesn't exist
3 participants
@Hee-San @dnfadmin @clairernovotny