Fuzzy month years logic for time span humanize extensions #632

MaStr11 · 2017-05-03T20:12:50Z

Fixes #583
This change now allows calls to TimeSpanHumanizeExtensions.Humanize with the parameter maxUnit and minUnit set to TimeUnit.Month or maxUnit: TimeUnit.Year. The duration in month and years is approximated based on 365.2425 days a year (length of the gregorian calendar). Therefore the month are alternating between 30 and 31 days and the years are alternating between 365 and 366 days.

The existing default value for maxUnit=TimeUnit.Week is kept because weeks are precise while month and year are not.

Most of the changes are related to the translation of the month and year identifiers. All text were translated with google translator except:

German I'm a native German.
Russian Reviewed by a native speaker.
fi-FI Tests and translations for timespan were already missing.
el Tests and translations for timespan were already missing.

I marked the test related to translations with the [Trait("Translation", "Google")] attribute to make clear which translations are of poor quality.

Checklist for the Translation Reviews:

… TimeUnit.Year with translations.

khellang

Norwegian looks good. I left some comments on the Danish and Swedish translations. Hopefully @thecodejunkie and @madstt can verify my corrections.

khellang · 2017-05-03T23:49:22Z

src/Humanizer/Properties/Resources.da.resx

+    <value>en måned</value>
+  </data>
+  <data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
+    <value>en år</value>


et år // @madstt?

that is correct, it is called 'et år' in Danish, not 'en år'...

khellang · 2017-05-03T23:53:37Z

src/Humanizer/Properties/Resources.sv.resx

+    <value>{0} år</value>
+  </data>
+  <data name="TimeSpanHumanize_SingleMonth" xml:space="preserve">
+    <value>1 månad</value>


en månad // @thecodejunkie?

khellang · 2017-05-03T23:53:52Z

src/Humanizer/Properties/Resources.sv.resx

+    <value>1 månad</value>
+  </data>
+  <data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
+    <value>1 år</value>


ett år // @thecodejunkie?

M-Zuber

Commented with fixes for the Hebrew translations (source: I speak it fluently)

M-Zuber · 2017-05-03T23:53:07Z

src/Humanizer/Properties/Resources.he.resx

+    <value>{0} שנים</value>
+  </data>
+  <data name="TimeSpanHumanize_MultipleYears_Dual" xml:space="preserve">
+    <value>שנים</value>


2 years is either: 2 שנים or שנתיים

M-Zuber · 2017-05-03T23:54:00Z

src/Humanizer/Properties/Resources.he.resx

+    <value>{0} חודשים</value>
+  </data>
+  <data name="TimeSpanHumanize_MultipleMonths_Dual" xml:space="preserve">
+    <value>חודשים</value>


2 months is either 2 חודשים or חודשיים

M-Zuber · 2017-05-03T23:55:20Z

src/Humanizer/TimeSpanHumanizeExtensions.cs


        /// <summary>
        /// Turns a TimeSpan into a human readable form. E.g. 1 day.
        /// </summary>
        /// <param name="timeSpan"></param>
        /// <param name="precision">The maximum number of time units to return. Defaulted is 1 which means the largest unit is returned</param>
        /// <param name="culture">Culture to use. If null, current thread's UI culture is used.</param>
-        /// <param name="maxUnit">The maximum unit of time to output.</param>
+        /// <param name="maxUnit">The maximum unit of time to output. The default value is <see cref="TimeUnit.Week"/>. The time units <see cref="TimeUnit.Month"/> and <see cref="TimeUnit.Year"/> will give approximations for time spans bigger 30 days by calculating with 365.2425 days a year and 30.4369 days a month.</param>


for time spans bigger 30 days -> for time spans bigger than 30 days

M-Zuber · 2017-05-04T00:01:36Z

src/Humanizer/Properties/Resources.he.resx

+    <value>חודש</value>
+  </data>
+  <data name="TimeSpanHumanize_SingleYear" xml:space="preserve">
+    <value>שנה אחת</value>


Can be shortened to just שנה

M-Zuber · 2017-05-04T00:01:45Z

Out of curiosity, as I can not pull down the code and test it myself,
what is displayed if the value is smaller than the TimeUnit passed?

clairernovotny · 2017-05-04T00:19:56Z

Thanks @M-Zuber @khellang @thecodejunkie @madstt for jumping in! I'm trying to get a 2.2 release out by Friday afternoon, and I'd love to get this included if the language updates can be incorporated and validated by then :)

jeremymeng · 2017-05-04T03:42:09Z

Chinese translations （all three) look good.

herecydev · 2017-05-04T05:40:36Z

Can confirm the Russian is all fine from a native speaker.

MaStr11 · 2017-05-04T07:32:51Z

@M-Zuber What is displayed if the value is smaller than the TimeUnit passed?
You can have a look at the test cases
TimeSpanWithMinTimeUnit and TimeSpanWithMaxTimeUnit. If minUnit==TimeUnit.Year and timeSpan<=365 than no time is returned. If maxUnit==TimeUnit.Month and timeSpan==366 than 12 months are returned.

…ked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending.

thecodejunkie · 2017-05-04T07:50:25Z

Swedish looks OK 👍

khellang · 2017-05-04T10:52:54Z

src/Humanizer.Tests.Shared/Localisation/nb-NO/TimeSpanHumanizeTests.cs

    {

        [Theory]
+        [Trait("Translation", "Google")]


These are also verified now 😄

clairernovotny · 2017-05-04T13:35:14Z

@MaStr11 is this basically ready with the stated manual/machine translations?

NinoFloris · 2017-05-04T13:50:36Z

Dutch (nl) looks totally fine

ctyar · 2017-05-04T14:00:27Z

Farsi translation looks good 👍

MaStr11 · 2017-05-04T14:06:42Z

@onovotny The current state of the Translations is:

Missing (timespan related translations are completely absent):

fi-FI
el

Reviewed by native speakers:

da (corrections pushed in commit 5a38789)
de
du
fa
he (corrections pushed in commit 5a38789)
nl
nb
ru
sv (corrections pushed in commit 5a38789)
zh

Others:

Translated by Google translate. I'm quite confident with the slavic anguages because I can read those and have a minor understanding of basic rules but africans, arabic, chinese korean japanese and the like are just copy&paste.

clairernovotny · 2017-05-04T14:31:43Z

merging into branch pr632 for others to easily fork/PR into it

#632 Continued: Fuzzy month years logic for time span humanize extensions

ds-b · 2017-05-05T08:51:42Z

src/Humanizer.Tests.Shared/Localisation/ro-Ro/TimeSpanHumanizerTests.cs

+
+        [Theory]
+        [Trait("Translation", "Google")]
+        [InlineData(366, "1 ani")]


It should be "1 an"

can you please submit a PR? no PR is too small :)

Changes are part of #636

Timespan fixes for Romanian (ref. #632)

MaStr11 added 4 commits May 3, 2017 20:55

Implemented TimeSpan Humanize extension method for TimeUnit.Month and…

23c4c2a

… TimeUnit.Year with translations.

Readme updated.

55af01c

Changes in csproj reverted.

4caa157

Test for uniqueness of day sequences added.

4c64630

khellang suggested changes May 3, 2017

View reviewed changes

M-Zuber reviewed May 3, 2017

View reviewed changes

M-Zuber reviewed May 4, 2017

View reviewed changes

clairernovotny added this to the v2.2 milestone May 4, 2017

Incorporated review comments by @khellang, @M-Zuber, @jeremymeng. Mar…

5a38789

…ked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending.

khellang reviewed May 4, 2017

View reviewed changes

clairernovotny mentioned this pull request May 4, 2017

Ship Humanizer 2.2 #627

Closed

Marked confirmed translations with "Native speaker".

dafcc6c

clairernovotny changed the base branch from dev to pr632 May 4, 2017 14:31

clairernovotny merged commit 0ab0d95 into Humanizr:pr632 May 4, 2017

clairernovotny mentioned this pull request May 4, 2017

#632 Continued: Fuzzy month years logic for time span humanize extensions #633

Merged

40 tasks

clairernovotny pushed a commit that referenced this pull request May 4, 2017

Merge pull request #633 from Humanizr/pr632

3bbcab0

#632 Continued: Fuzzy month years logic for time span humanize extensions

ds-b reviewed May 5, 2017

View reviewed changes

MaStr11 mentioned this pull request May 5, 2017

Added tests for Greek deleted obsolet entries in resx. Corrected Roma… #636

Merged

MaStr11 deleted the FuzzyMonthYearsLogicForTimeSpanHumanizeExtensions branch May 5, 2017 19:26

cristianst85 mentioned this pull request May 5, 2017

Timespan fixes for Romanian (ref. #632) #637

Merged

clairernovotny pushed a commit that referenced this pull request Nov 3, 2017

Merge pull request #637 from cristianst85/timespan-fixes-ro

83d076f

Timespan fixes for Romanian (ref. #632)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fuzzy month years logic for time span humanize extensions #632

Fuzzy month years logic for time span humanize extensions #632

MaStr11 commented May 3, 2017 •

edited

Loading

khellang left a comment

khellang May 3, 2017

madstt May 4, 2017

khellang May 3, 2017

khellang May 3, 2017 •

edited

Loading

M-Zuber left a comment

M-Zuber May 3, 2017

M-Zuber May 3, 2017

M-Zuber May 3, 2017

M-Zuber May 4, 2017

M-Zuber commented May 4, 2017

clairernovotny commented May 4, 2017

jeremymeng commented May 4, 2017

herecydev commented May 4, 2017

MaStr11 commented May 4, 2017 •

edited

Loading

thecodejunkie commented May 4, 2017

khellang May 4, 2017

clairernovotny commented May 4, 2017

NinoFloris commented May 4, 2017

ctyar commented May 4, 2017

MaStr11 commented May 4, 2017 •

edited

Loading

clairernovotny commented May 4, 2017

ds-b May 5, 2017

clairernovotny May 5, 2017

MaStr11 May 5, 2017

Fuzzy month years logic for time span humanize extensions #632

Fuzzy month years logic for time span humanize extensions #632

Conversation

MaStr11 commented May 3, 2017 • edited Loading

khellang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khellang May 3, 2017 • edited Loading

Choose a reason for hiding this comment

M-Zuber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

M-Zuber commented May 4, 2017

clairernovotny commented May 4, 2017

jeremymeng commented May 4, 2017

herecydev commented May 4, 2017

MaStr11 commented May 4, 2017 • edited Loading

thecodejunkie commented May 4, 2017

Choose a reason for hiding this comment

clairernovotny commented May 4, 2017

NinoFloris commented May 4, 2017

ctyar commented May 4, 2017

MaStr11 commented May 4, 2017 • edited Loading

clairernovotny commented May 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaStr11 commented May 3, 2017 •

edited

Loading

khellang May 3, 2017 •

edited

Loading

MaStr11 commented May 4, 2017 •

edited

Loading

MaStr11 commented May 4, 2017 •

edited

Loading