Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency (NuGet package ref) with frameworkAssembly #522

Closed
wants to merge 1 commit into from

Conversation

MatthewSteeples
Copy link
Contributor

No description provided.

@clairernovotny
Copy link
Member

Thanks for the PR. Unfortunately, as-is, this will not work as it breaks support for .NET Core.

We do not need frameworkAssembly here, we really do need the dependencies. Please see my blog post for the detailed explanation:
https://oren.codes/2015/07/29/targeting-net-core/

These dependencies do install on .NET 4.5 and they're harmless. Trying to add empty dependency groups will cause issues down the road as specific TFM > dotnet > portable-*. These packages are the same reference assemblies that live on your computer used by the PCL project system but are now available to dotnet CLI and project.json.

@clairernovotny
Copy link
Member

closing as this should be resolved in 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants