Skip to content

Conversation

@emcbem
Copy link
Contributor

@emcbem emcbem commented Oct 11, 2024

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

fixes #1241

emcbem and others added 6 commits October 10, 2024 17:49
Co-authored-by: Bryce Coon <brycegcoon@gmail.com>
Co-authored-by: Parker Swenson <parkerswenson00@gmail.com>
Co-authored-by: Bryce Coon <brycegcoon@gmail.com>
Co-authored-by: Parker Swenson <parkerswenson00@gmail.com>
@clairernovotny clairernovotny enabled auto-merge May 7, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ByteSize should include petabyte, exabyte, etc.

2 participants