Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert in GetRomanNumeralCharValue #1512

Merged
merged 1 commit into from
May 30, 2024

Conversation

stephentoub
Copy link
Contributor

Should have been upper instead of lower. Not sure why CI didn't fail, unless it's only running tests against release?

Should have been upper instead of lower. Not sure why CI didn't fail, unless it's only running tests against release?
@SimonCropp
Copy link
Collaborator

running tests against release?

yep the ci build is built and tested in release mode

@SimonCropp SimonCropp merged commit ed39e05 into Humanizr:main May 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants